Security: Potential open redirect due to unvalidated redirect path fallback logic#14778
Open
tuanaiseo wants to merge 1 commit intoaws-amplify:mainfrom
Conversation
…ated redirec `getRedirectOrDefault` returns the provided `redirect` string directly when present. If this value is user-controlled and later used in a redirect response, it can enable open redirect attacks to external sites. Affected files: getRedirectOrDefault.ts Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
tuanaiseo
requested review from
avi-karthik,
pranavosu and
sarayev
as code owners
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
getRedirectOrDefaultreturns the providedredirectstring directly when present. If this value is user-controlled and later used in a redirect response, it can enable open redirect attacks to external sites.Severity:
mediumFile:
packages/adapter-nextjs/src/auth/utils/getRedirectOrDefault.tsSolution
Validate redirect targets before use: allow only relative paths (e.g., starting with
/and not//) or enforce a strict origin allowlist for absolute URLs. Normalize and reject invalid or external destinations.Changes
packages/adapter-nextjs/src/auth/utils/getRedirectOrDefault.ts(modified)Testing