Skip to content

chore(logging): move shared code to internal module#4206

Merged
harsh62 merged 5 commits into
feat/v3-cloudwatch-clientfrom
cloudwatch-client-2
May 8, 2026
Merged

chore(logging): move shared code to internal module#4206
harsh62 merged 5 commits into
feat/v3-cloudwatch-clientfrom
cloudwatch-client-2

Conversation

@thisisabhash
Copy link
Copy Markdown
Member

Issue #

None

Description

Move shared code between client and plugin to internal module

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds with all target using Swift Package Manager
  • All unit tests pass
  • All integration tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • New or updated tests include Given When Then inline code documentation and are named accordingly testThing_condition_expectation()
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@thisisabhash thisisabhash requested a review from a team as a code owner May 4, 2026 23:42
Base automatically changed from cloudwatch-client-1 to feat/v3-cloudwatch-client May 8, 2026 18:46
@harsh62 harsh62 merged commit 52d6286 into feat/v3-cloudwatch-client May 8, 2026
87 of 93 checks passed
@harsh62 harsh62 deleted the cloudwatch-client-2 branch May 8, 2026 18:55
thisisabhash added a commit that referenced this pull request May 8, 2026
* feat(logging): add v3 cloudwatch @SPI definitions

* add privacyinfo

* chore(logging): move shared code to internal module

* fix unit tests

---------

Co-authored-by: Harsh <6162866+harsh62@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants