POC(liveness): allow back camera selection#5370
POC(liveness): allow back camera selection#5370esauerbo wants to merge 1 commit intoliveness/alphafrom
Conversation
|
| isStartView && | ||
| selectableDevices && | ||
| selectableDevices.length > 1 && | ||
| (!isMobileScreen || (allowBackCamera && isFaceMovementChallenge)); |
There was a problem hiding this comment.
Makes sense to me, only allow camera selection on mobile if allowBackCamera and is face movement challenge
There was a problem hiding this comment.
+1, this is a very readable conditional, nice work!
| * Optional parameter for advanced options for the component | ||
| */ | ||
| config?: FaceLivenessDetectorCoreConfig; | ||
| allowBackCamera?: boolean; |
There was a problem hiding this comment.
I think we will want to have a conversion about whether this should be in the config or a top level prop.
3 participants
Description of changes
Issue #, if available
Description of how you validated changes
Checklist
yarn testpasses and tests are updated/addeddocs,e2e,examples, or other private packages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.