Add services override for forcing new password#6604
Open
jiw-mh wants to merge 1 commit intoaws-amplify:mainfrom
Open
Add services override for forcing new password#6604jiw-mh wants to merge 1 commit intoaws-amplify:mainfrom
jiw-mh wants to merge 1 commit intoaws-amplify:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 3c0b793 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
8119bcd to
91ce5db
Compare
91ce5db to
30bcd19
Compare
Member
|
hey @jiw-mh thanks for raising the PR. contributions are always very welcome. the code looks good, I'd just like to see a test added, for the signIn-actor, so that a |
30bcd19 to
3c0b793
Compare
Author
|
@bobbor I rebased the PR and found a problem that would stop the tests from passing. I tried today to add a test, but since the current tests are skipped and trying to re-enable them has been fruitless so far, as I am not familiar with the changes and it seems more than a little is broken. It would be nice if there was advice/help on how to add a test around that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds a way to override/extend the confirmSignIn call done when the new password dialog is done.
Description of how you validated changes
Checklist
yarn testpasses and tests are updated/addeddocs,e2e,examples, or other private packages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.