Skip to content

Add services override for forcing new password#6604

Open
jiw-mh wants to merge 1 commit intoaws-amplify:mainfrom
jiw-mh:feat/service-hook-force-new-password
Open

Add services override for forcing new password#6604
jiw-mh wants to merge 1 commit intoaws-amplify:mainfrom
jiw-mh:feat/service-hook-force-new-password

Conversation

@jiw-mh
Copy link
Copy Markdown

@jiw-mh jiw-mh commented Jun 27, 2025

Description of changes

Adds a way to override/extend the confirmSignIn call done when the new password dialog is done.

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jiw-mh jiw-mh requested a review from a team as a code owner June 27, 2025 04:24
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 27, 2025

🦋 Changeset detected

Latest commit: 3c0b793

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@aws-amplify/ui Minor
@aws-amplify/ui-react-core-notifications Patch
@aws-amplify/ui-react-core Patch
@aws-amplify/ui-react-liveness Patch
@aws-amplify/ui-react-native Patch
@aws-amplify/ui-react-notifications Patch
@aws-amplify/ui-react-storage Patch
@aws-amplify/ui-react Patch
@aws-amplify/ui-svelte Patch
@aws-amplify/ui-vue Patch
@aws-amplify/ui-angular Patch
@aws-amplify/ui-react-geo Patch
@aws-amplify/ui-test-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jiw-mh jiw-mh force-pushed the feat/service-hook-force-new-password branch 2 times, most recently from 8119bcd to 91ce5db Compare July 2, 2025 04:35
@jiw-mh jiw-mh force-pushed the feat/service-hook-force-new-password branch from 91ce5db to 30bcd19 Compare July 31, 2025 04:32
@bobbor
Copy link
Copy Markdown
Member

bobbor commented Dec 12, 2025

hey @jiw-mh

thanks for raising the PR. contributions are always very welcome.

the code looks good, I'd just like to see a test added, for the signIn-actor, so that a handleForceChangePassword service function provided is actually called, with the correct input.

@bobbor bobbor added run-tests Adding this label will trigger tests to run and removed run-tests Adding this label will trigger tests to run labels Dec 12, 2025
@bobbor bobbor self-assigned this Dec 12, 2025
@jiw-mh jiw-mh force-pushed the feat/service-hook-force-new-password branch from 30bcd19 to 3c0b793 Compare April 21, 2026 08:53
@jiw-mh
Copy link
Copy Markdown
Author

jiw-mh commented Apr 21, 2026

@bobbor I rebased the PR and found a problem that would stop the tests from passing. I tried today to add a test, but since the current tests are skipped

it.skip('transitions to forceNewPassword when challengeName is NEW_PASSWORD_REQUIRED', async () => {
and trying to re-enable them has been fruitless so far, as I am not familiar with the changes and it seems more than a little is broken. It would be nice if there was advice/help on how to add a test around that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-tests Adding this label will trigger tests to run

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants