Merge pull request #132 from vulkoingim/fix-respect-endpoint-url

Fix AWS_ENDPOINT_URL following spec

Author: onno-vos-dev

lib/aws_codegen/post_service.ex

@@ -111,7 +111,12 @@ defmodule AWS.CodeGen.PostService do
       signing_name: signing_name,
       signature_version: AWS.CodeGen.Util.get_signature_version(service),
       service_id: AWS.CodeGen.Util.get_service_id(service),
-      endpoint_url_env_var: "AWS_ENDPOINT_URL_" <> spec.module_name |> String.upcase(),
+      endpoint_url_env_var:
+        "AWS_ENDPOINT_URL_" <>
+          (service
+           |> AWS.CodeGen.Util.get_service_id()
+           |> String.replace(" ", "_")
+           |> String.upcase()),
       target_prefix: target_prefix(spec.api)
     }
   end

lib/aws_codegen/rest_service.ex

@@ -157,7 +157,12 @@ defmodule AWS.CodeGen.RestService do
       signing_name: signing_name,
       signature_version: AWS.CodeGen.Util.get_signature_version(service),
       service_id: AWS.CodeGen.Util.get_service_id(service),
-      endpoint_url_env_var: "AWS_ENDPOINT_URL_" <> spec.module_name |> String.upcase(),
+      endpoint_url_env_var:
+        "AWS_ENDPOINT_URL_" <>
+          (service
+           |> AWS.CodeGen.Util.get_service_id()
+           |> String.replace(" ", "_")
+           |> String.upcase()),
       ## TODO: metadata["targetPrefix"],
       target_prefix: nil,
       shapes: Shapes.collect_shapes(language, spec.api)

test/aws_codegen/rest_service_test.exs

@@ -51,7 +51,7 @@ defmodule AWS.CodeGen.RestServiceTest do
                module_name: "AWS.CloudTrailData",
                protocol: "rest-json",
                service_id: "CloudTrail Data",
-               endpoint_url_env_var: "AWS_ENDPOINT_URL_AWS.CLOUDTRAILDATA", # For Erlang this would be: AWS_ENDPOINT_URL_CLOUDTRAILDATA
+               endpoint_url_env_var: "AWS_ENDPOINT_URL_CLOUDTRAIL_DATA",
                signature_version: "v4",
                signing_name: "cloudtrail-data",
                target_prefix: nil