Commit f645048
committed
Filter unknown options before passing to Finch.request/3
Finch 0.21.0 validates the options keyword list and raises
ArgumentError when unknown keys are passed. Since v0.21.0, the only
allowed keys are :pool_timeout, :receive_timeout, :request_timeout,
and :pool_strategy.
Previously the entire options keyword list (including :finch_name) was
forwarded to Finch.request/3, which now fails with:
** (ArgumentError) unknown keys [:finch_name] in [finch_name: MyFinch],
the allowed keys are: [:pool_timeout, :receive_timeout,
:request_timeout, :pool_strategy]
Filter the options down to the keys Finch accepts before forwarding.
No new tests were added because this was already caught by the current
test suite after updating the finch dependency via
`test/aws/http_client_test.exs:82`
Fixes: #228
See: sneako/finch#3651 parent ed8eab4 commit f645048
1 file changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
| 24 | + | |
23 | 25 | | |
24 | 26 | | |
25 | 27 | | |
26 | 28 | | |
27 | 29 | | |
| 30 | + | |
| 31 | + | |
28 | 32 | | |
29 | 33 | | |
30 | 34 | | |
31 | | - | |
| 35 | + | |
32 | 36 | | |
33 | 37 | | |
34 | 38 | | |
| |||
0 commit comments