Add rule E3064: duplicate Interface VPC Endpoint with PrivateDnsEnabled#4492
Merged
Merged
Conversation
2403194 to
c264b08
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4492 +/- ##
==========================================
+ Coverage 93.49% 93.51% +0.02%
==========================================
Files 460 461 +1
Lines 15037 15101 +64
Branches 2907 2924 +17
==========================================
+ Hits 14059 14122 +63
Misses 599 599
- Partials 379 380 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Detect when multiple AWS::EC2::VPCEndpoint resources in the same template share the same VpcId, ServiceName, VpcEndpointType: Interface, and PrivateDnsEnabled: true. AWS rejects the second endpoint with a conflicting DNS domain error. Fixes aws-cloudformation#4352
c264b08 to
03de5f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add rule E3064 to detect when multiple
AWS::EC2::VPCEndpointresources in the same template have the sameVpcId,ServiceName,VpcEndpointType: Interface, andPrivateDnsEnabled: true. AWS rejects the second endpoint at deploy time with a conflicting DNS domain error, causing a stack rollback.What was tested
Test cases (12)
Fn::Ifon PrivateDnsEnabled (valid)Fn::Ifon VpcId matching saved in same condition (error)Fn::Ifon PrivateDnsEnabled resolving to false (valid)Fn::Ifon ServiceName matching saved in same condition (error)Fixes #4352