Fix Elasticsearch domain instance type enum

[0xTaoZ]

What

Fixes the regional instance type enum used by AWS::Elasticsearch::Domain so the legacy Elasticsearch resource accepts .elasticsearch instance type names instead of OpenSearch .search names.

Why

AWS::Elasticsearch::Domain still uses legacy Elasticsearch instance type names such as m6g.large.elasticsearch. The enum for E3652 was populated with .search values, which causes valid legacy templates to fail linting.

Fixes #4565.

Details

This updates the generated enum data for the legacy Elasticsearch resource while leaving the OpenSearch resource enum separate. I also added a good fixture covering the false-positive case from #4565.

If maintainers prefer this to be fixed in the pricing/spec update path instead of committing the generated enum directly, I am happy to adjust the PR.

Testing

• git diff --check
• confirmed m6g.large.elasticsearch is present in the us-east-1 enum and m6g.large.search is no longer present for the legacy Elasticsearch enum

Note: full local cfn-lint execution could not complete in my environment because enhanced schema download failed with a local SSL certificate verification error.

[kddejong]

Thanks for submitting @0xTaoZ based on this I submitted #4569 if you can review that it would be great but this should resolve it going forward.