Conversation
kddejong
previously approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces a
FileDbfeature flag to control the persistence backend. When enabled, the language server usesFileStoreFactoryinstead ofLMDBStoreFactory. This enables a gradual migration away from LMDB via fleet percentage rollout.The DataStore is selected based on the feature flag and operating system ONCE on startup - we can't hot swap the database even if the feature flag flips.
Key Changes
FileDbto alpha (on, 100%), beta (off, 100%), prod (off, 0%)MultiDataStoreFactoryProvidernow takes aFeatureFlagand uses it to pickFileStoreFactoryvsLMDBStoreFactoryFeatureFlagProvidermoved fromCfnExternal→CfnInfraCore(core now depends on it for datastore init)FeatureFlagSupplierloops useas const satisfiesfor proper typed keys instead ofRecord<string, ...>featureFlagLocalFile()andrelationshipLocalFile()— testable path buildersreadBufferIfExistsreturn typeNonSharedBuffer→Buffer;sleepexported fromRetry.tsAndFeatureFlag,LocalHostTargetedFeatureFlag,buildLocalHost,featureFlagLocalFile,Fileutils,sleepFeature Flag settings until we test