Skip to content

Collect all unknown parameters before reporting #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
railsharipov wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Collect all unknown parameters before reporting #778

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions internal/dc/dc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,17 @@ func GetParameters(

if params, ok := template.Map()["Parameters"]; ok {
// Check we don't have any unknown params
unknownParams := make([]string, 0)
for k := range combinedParameters {
if _, ok := params.(map[string]interface{})[k]; !ok {
if ignoreUnknownParams {
fmt.Println(console.Yellow(fmt.Sprintf("unknown parameter: %s", k)))
} else {
panic(fmt.Errorf("unknown parameter: %s\nif you want to proceed as is, add the --ignore-unknown-params flag", k))
}
unknownParams = append(unknownParams, k)
}
}
if len(unknownParams) > 0 {
if ignoreUnknownParams {
fmt.Println(console.Yellow(fmt.Sprintf("unknown parameters: %v", unknownParams)))
} else {
panic(fmt.Errorf("unknown parameters: %v\nif you want to proceed as is, add the --ignore-unknown-params flag", unknownParams))
}
}

Expand Down