Skip to content

Update acm SDK to v1.42.0 and regenerate#109

Open
KyleBS wants to merge 1 commit into
aws-controllers-k8s:mainfrom
KyleBS:regenerate-against-sdk-v1.42.0
Open

Update acm SDK to v1.42.0 and regenerate#109
KyleBS wants to merge 1 commit into
aws-controllers-k8s:mainfrom
KyleBS:regenerate-against-sdk-v1.42.0

Conversation

@KyleBS

@KyleBS KyleBS commented Jul 17, 2026

Copy link
Copy Markdown

Issue #, if available: N/A

Description of changes: Bumps github.com/aws/aws-sdk-go-v2/service/acm from v1.33.0 to v1.42.0 and regenerates against the latest code-generator. This is a regeneration-only change with no new functionality:

  • Certificate doc-comment/URL refresh from the newer SDK model
  • New v1.42.0 model shapes emitted into types.go/enums.go/deepcopy
  • Metadata now records a clean code-generator version and aws_service_sdk_version v1.42.0

The ACME resources (AcmeEndpoint, AcmeExternalAccountBinding, AcmeDomainValidation) present in the v1.42.0 model are ignored via ignore.resource_names; the controllers for them are added in a follow-up PR.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Bumps github.com/aws/aws-sdk-go-v2/service/acm from v1.33.0 to v1.42.0
and regenerates against the latest code-generator. This is a
regeneration-only change with no new functionality:

- Certificate doc-comment/URL refresh from the newer SDK model
- New v1.42.0 model shapes emitted into types.go/enums.go/deepcopy
- Metadata now records a clean code-generator version and
  aws_service_sdk_version v1.42.0

The ACME resources (AcmeEndpoint, AcmeExternalAccountBinding,
AcmeDomainValidation) present in the v1.42.0 model are ignored via
ignore.resource_names; the controllers for them are added in a
follow-up PR.
@ack-prow
ack-prow Bot requested review from gustavodiaz7722 and knottnt July 17, 2026 18:42
@ack-prow

ack-prow Bot commented Jul 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: KyleBS
Once this PR has been reviewed and has the lgtm label, please assign knottnt for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 17, 2026
@ack-prow

ack-prow Bot commented Jul 17, 2026

Copy link
Copy Markdown

Hi @KyleBS. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant