fix: fail on missing CRDs for compat-check command (#679)

michaelhtm · web-flow · commit f0b080577c1e · 2026-03-17T16:20:43.000Z
Description of changes:
This command is meant to be ran inside an ACK controller directory.
Currently it has been silently failing if it can't discover missing
CRDs. With this change, we will fail if we can't detect CRD files.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
diff --git a/cmd/ack-generate/command/crd_compat_check.go b/cmd/ack-generate/command/crd_compat_check.go
@@ -70,7 +70,7 @@ func checkCRDCompat(cmd *cobra.Command, args []string) error {
 
 	if len(crdFiles) == 0 {
 		fmt.Println("No CRD files found, nothing to check.")
-		return nil
+		return fmt.Errorf("no CRD files found in %v", optCRDPaths)
 	}
 
 	hasBreaking := false

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,7 @@ func checkCRDCompat(cmd *cobra.Command, args []string) error {`
`70`	`70`
`71`	`71`	`if len(crdFiles) == 0 {`
`72`	`72`	`fmt.Println("No CRD files found, nothing to check.")`
`73`		`- return nil`
	`73`	`+ return fmt.Errorf("no CRD files found in %v", optCRDPaths)`
`74`	`74`	`}`
`75`	`75`
`76`	`76`	`hasBreaking := false`