Skip to content

test: add E2E tests for --enable-cross-namespace flag#175

Open
sapphirew wants to merge 1 commit into
aws-controllers-k8s:mainfrom
sapphirew:test/cross-namespace
Open

test: add E2E tests for --enable-cross-namespace flag#175
sapphirew wants to merge 1 commit into
aws-controllers-k8s:mainfrom
sapphirew:test/cross-namespace

Conversation

@sapphirew

@sapphirew sapphirew commented May 7, 2026

Copy link
Copy Markdown

Issue #, if available:

Description of changes:

Regenerate iam-controller using updated code-generator and runtime that introduce the unified --enable-cross-namespace flag with phased rollout.

Generated code changes:

  • Renames EnableCrossNamespaceReferences to EnableCrossNamespace
  • Updates ValidateCrossNamespaceReference to return (string, bool, error)
  • Adds --enable-cross-namespace flag to Helm deployment template
  • Adds enableCrossNamespace: true to Helm values (Phase 1 default)

E2E tests cover three scenarios:

  • flag=true (Phase 1 default): cross-namespace ref succeeds with ACK.CrossNamespaceDeprecation condition as deprecation warning
  • flag=false: cross-namespace ref rejected with ACK.Terminal condition containing the --enable-cross-namespace flag name
  • same-namespace: ref always succeeds regardless of flag value with no deprecation condition present

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow
ack-prow Bot requested review from gustavodiaz7722, jlbutler and knottnt May 7, 2026 01:05
@kprahulraj kprahulraj mentioned this pull request May 21, 2026
Closed
@kprahulraj

kprahulraj commented May 21, 2026

Copy link
Copy Markdown

Doc changes is added - aws-controllers-k8s/docs#37

@sapphirew
sapphirew force-pushed the test/cross-namespace branch 4 times, most recently from 209b346 to d616ec2 Compare May 28, 2026 17:35
@sapphirew sapphirew changed the title [Draft] feat: add E2E tests for --enable-cross-namespace flag test: add E2E tests for --enable-cross-namespace flag May 28, 2026
@sapphirew
sapphirew force-pushed the test/cross-namespace branch from d616ec2 to 01b525c Compare May 28, 2026 21:29
@sapphirew
sapphirew force-pushed the test/cross-namespace branch from 01b525c to 9e75700 Compare June 23, 2026 19:13
@ack-prow

ack-prow Bot commented Jun 23, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sapphirew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow Bot added the approved label Jun 23, 2026
@sapphirew
sapphirew force-pushed the test/cross-namespace branch from 9e75700 to 5d0579a Compare June 23, 2026 19:22
@sapphirew
test(e2e): Add cross-namespace reference E2E tests
2c8fbc7 
The --enable-cross-namespace flag, generated reference resolution code,
and Helm wiring already shipped upstream in iam-controller v1.7.2
(ACK runtime v0.60.0). This adds end-to-end test coverage for the
cross-namespace behavior across the three scenarios: flag enabled
(deprecation advisory), flag disabled (terminal rejection), and
same-namespace (always allowed).
@sapphirew
sapphirew force-pushed the test/cross-namespace branch from 5d0579a to 2c8fbc7 Compare June 23, 2026 20:29
@ack-prow

ack-prow Bot commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown

@sapphirew: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
iam-crd-compat-check 5284d5a link true /test iam-crd-compat-check

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sapphirew

sapphirew commented Jun 23, 2026

Copy link
Copy Markdown
Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gustavodiaz7722 gustavodiaz7722 Awaiting requested review from gustavodiaz7722
@jlbutler jlbutler Awaiting requested review from jlbutler
@knottnt knottnt Awaiting requested review from knottnt

Assignees

No one assigned

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sapphirew @kprahulraj