test(core): incorporate JSON-RPC review feedback

Author: ikenyal

packages/core/src/rpc.test.ts

@@ -87,7 +87,7 @@ describe('-32602 Invalid Params validation', () => {
     }
   });
 
-  it('accepts named object params using their value order', () => {
+  it('accepts named object params', () => {
     const result = parseRpcRequest(JSON.stringify({
       jsonrpc: '2.0',
       method: 'api.echo',
@@ -114,7 +114,7 @@ describe('-32602 Invalid Params validation', () => {
     }
   });
 
-  for (const params of ['abc', 42, true, null]) {
+  for (const params of ['abc', 42, true, false, null]) {
     it(`rejects ${JSON.stringify(params)} params`, () => {
       const result = parseRpcRequest(JSON.stringify({
         jsonrpc: '2.0',
@@ -128,6 +128,7 @@ describe('-32602 Invalid Params validation', () => {
         const response = JSON.parse(result.response);
         assert.strictEqual(response.error.code, RpcErrorCode.InvalidParams);
         assert.strictEqual(response.error.data.name, 'InvalidParams');
+        assert.ok(response.error.message.includes('expected an array or object'));
         assert.strictEqual(response.id, 'request-1');
       }
     });

packages/core/src/rpc.ts

@@ -141,7 +141,7 @@ export function parseRpcRequest(bodyText: string): RpcParseResult {
     request: {
       apiNamespace: parsed.method.substring(0, dotIndex),
       method: parsed.method.substring(dotIndex + 1),
-      // JSON-RPC 2.0 §4.2: params may be an array (positional) or object (named).
+      // JSON-RPC 2.0 §4.2: params may be array (positional), object (named), or omitted (empty).
       args,
       id,
     },