docs(bench): add pr-agent-bench skill (how-to-read runbook)#218
Open
hfurkanbozkurt wants to merge 10 commits into
Open
docs(bench): add pr-agent-bench skill (how-to-read runbook)#218hfurkanbozkurt wants to merge 10 commits into
hfurkanbozkurt wants to merge 10 commits into
Conversation
This was referenced Jul 17, 2026
added 2 commits
July 17, 2026 20:49
…or slug - trace caveat: only an ungraceful GitHub SIGKILL (hard timeout-minutes:35 kill before the graceful flush) writes no trace.json; the internal-deadline path (BENCH_AGENT_DEADLINE_SEC, stop_reason wall_clock_timeout) now flushes a message-only trace, so timed-out cells stay analyzable; genuinely trace-less => stop_reason is the answer (infra -> re-run) - fix intra-doc anchor: change em-dash to colon in the 'Reference:' header so its GitHub slug is single-hyphen, matching the existing [reference](#reference-what-the-current-v1-report-contains) link
|
added 3 commits
July 17, 2026 23:39
…er are counted (INCLUDED), only harness_error is excluded Step 2 previously bucketed dead_server, wall_clock_timeout, max_tokens and agent_timeout as 'infra/harness noise -> NOT a PR signal -> re-run', contradicting scoring.mjs (isCountedFailKlass: agent_fail + dead_server are INCLUDED as composite 0) and the SKILL's own Reference section. Rewrote the triage table into 3 classes matching scoring.mjs exactly: harness_error (EXCLUDED, re-run/not a PR signal), agent_fail + dead_server (INCLUDED composite-0 counted failures that moved the mean; re-run only to disambiguate transient-vs-real), scored (INCLUDED, graded). Added a 'trap to avoid' note and corrected the worked-example cognito bullet to call the max_tokens 0 a counted agent_fail, not excluded noise.
…/B live in judge artifact JSON, not the row
hfurkanbozkurt
marked this pull request as ready for review
July 19, 2026 20:35
added 3 commits
July 20, 2026 05:30
…nt-bench-skill Brings in the #216 review-nit doc fixes (via the harness-integrity forward-merge). Additive merge; no history rewrite.
dev_server_dead sat under a column headed 'Signal (stop_reason / status)' but it is a klass_reason, not a stop_reason. Broaden the heading to 'stop_reason / klass_reason / status' so the dead_server cell is labeled accurately, consistent with the Reference section's stop_reason enumeration (which correctly omits dev_server_dead).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 3 of 3 — split of #194. Stacked on PR 2 (base branch
bench/harness-integrity).Concern: docs only. Adds
.agents/skills/pr-agent-bench/SKILL.md— a passive skill / runbook for reading and interpreting an aws-blocks PR agent-bench run: what the report's columns, colored balls (🟢 ⚪ 🟡 🔴), Judge dimensions (F/S/P/C/B), composite/Score, andstop_reasonvalues mean, plus a 60-second regression-triage runbook.Single commit
ab85029; the diff touches only that one new file (+187). No code, no published@aws-blocks/*package changes.Base:
bench/harness-integrity(PR 2).Stack (bottom → top): #216 ← #217 ← #218 · supersedes #194.
Supersedes #194.