fix(create-blocks-app): register Amplify auth config#233
Open
ikenyal wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: a7e7769 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Amplify Gen 2 overlay adds Cognito values directly to the shared Blocks Lambda environment. This bypasses the shared config registry and consumes the Lambda environment-variable budget. It also injects
COGNITO_REGION, which the generated Cognito verifier does not read.Issue #, if available: N/A
Changes
registerConfig()from@aws-blocks/blocks/cdk.COGNITO_REGIONinjection.@aws-blocks/create-blocks-app.Validation
npm run build --workspace @aws-blocks/create-blocks-appnpm test --workspace @aws-blocks/create-blocks-app(50 passing tests)npx tsc --noEmit --target ES2022 --module NodeNext --moduleResolution NodeNext --skipLibCheck test-apps/amplify-gen2/amplify/blocks.tsnpm run lint:depschangeset status --since=origin/mainChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.