test(bench): fail shared no-error gate on console errors + strengthen task assertions (split from #216)#240
Open
hfurkanbozkurt wants to merge 1 commit into
Open
Conversation
… task assertions (split from #216)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Splits the
tasks/**test-hardening changes out of #216 (bench/report-single-table) into this standalone PR offmain. These changes are independent of #216's bench report-render redesign and stand on their own, so they're being landed separately.The corresponding
tasks/edits have been removed from #216 (and forward-merged up the stack #217 → #218) so the stack no longer carries them.What's in here (
tasks/**only — 12 files, +148/-14)Shared no-error gate added to
watchErrors()in all 10 task specs so a spec now fails on unexpectedconsole.erroroutput:async-word-counter,auth-notes,cognito-profile,collab-presence-board,email-digest,file-gallery,kb-chat-agent,observability-api,oidc-dsql-notes,sql-kb-catalogStrengthened assertions:
observability-api: +1 test (assertsapi.echorejects falsy args)oidc-dsql-notes: +1 test (unauthenticated note creation is refused)sql-kb-catalog: +2toContainText(/refund/i)catalog assertionsFixes:
async-word-counter:wc-listwait changedtoBeVisible→toBeAttached(more robust)async-word-counter/PROMPT.md: punctuation fixemail-digest/PROMPT.md: scope-note clarificationChangeset
No changeset required.
verify-changeset-coverage.tsonly requires a changeset for files underpackages/**(publishable@aws-blocks/*packages);tasks/**are benchmark fixtures, not published packages, so the check reports "No publishable packages were changed." Confirmed againstscripts/verify-changeset-coverage.tsand.github/workflows/changeset-check.yml.Split from #216. Draft.