fix(create-blocks-app): include Amplify dev server template#242
Open
ikenyal wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: d0bb476 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue #, if available: Fixes #241
When AWS Blocks is added to an Amplify Gen 2 project, the CLI adds
blocks:devwithtsx watch aws-blocks/scripts/server.ts. The Amplify overlay did not include that file, so the documented command immediately failed withERR_MODULE_NOT_FOUND.This is present in the published
@aws-blocks/create-blocks-apppackage as well as in the repository source.Changes
aws-blocks/scripts/server.tstemplate, using the existing backend-template local server pattern on port 3001.blocks:devscript has a matching server file.@aws-blocks/create-blocks-app.Validation
npm run buildnpm run lint:depsnpm testnpm run test:e2e:local(comprehensive: 372 passed, 0 failed, 1 skipped; vendorize: 8 passed, 0 failed)npm pack --dry-run --workspace @aws-blocks/create-blocks-appconfirms the new template is included.npx changeset statusChecklist
blocks:devcommand; it adds no new user-facing workflow or API documentation.)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.