Skip to content

sample yaml file for NGINX Mon Pattern Traffic Routing and NGINX resource issue#34

Merged
elamaran11 merged 2 commits into
aws-observability:mainfrom
joozero:main
Oct 31, 2023
Merged

sample yaml file for NGINX Mon Pattern Traffic Routing and NGINX resource issue#34
elamaran11 merged 2 commits into
aws-observability:mainfrom
joozero:main

Conversation

@joozero

@joozero joozero commented Oct 28, 2023

Copy link
Copy Markdown
Contributor

Issue #, if available:
aws-observability/cdk-aws-observability-accelerator#125

Description of changes:
Since origin yaml file is outdated, it disturbs customer's nginx observability accelerator hands-on-lab experience.
Also, PR has been up for several months, yet the changes have not been reflected.
(relevant link: aws-samples/amazon-cloudwatch-container-insights#120)

To mitigate this, add latest yaml file to this repo for customer's smooth hands-on-lab experience.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

elamaran11
elamaran11 previously approved these changes Oct 30, 2023

@elamaran11 elamaran11 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elamaran11

Copy link
Copy Markdown
Contributor

@joozero Please fix the GH action warnings.

@elamaran11 elamaran11 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elamaran11 elamaran11 merged commit 22599dd into aws-observability:main Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants