Skip to content

Add ap-east-2 and ap-southeast-6 to release build default regions#1367

Merged
viw-test1 merged 3 commits intoaws-observability:mainfrom
viw-test1:add-new-commercial-regions
Apr 25, 2026
Merged

Add ap-east-2 and ap-southeast-6 to release build default regions#1367
viw-test1 merged 3 commits intoaws-observability:mainfrom
viw-test1:add-new-commercial-regions

Conversation

@viw-test1
Copy link
Copy Markdown
Contributor

Issue #, if available:

Description of changes:
Add 2 new region to the build release

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@viw-test1 viw-test1 self-assigned this Apr 23, 2026
@viw-test1 viw-test1 requested a review from a team as a code owner April 23, 2026 20:18
@viw-test1 viw-test1 added the skip changelog doesn't need a CHANGELOG entry label Apr 23, 2026
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review - PR #1367

Overall Assessment: No bugs or security issues found.

This PR adds two new AWS regions (ap-east-2 and ap-southeast-6) to the aws_region default input for the release build workflow. The changes are correctly placed:

  • ap-east-2 is inserted after ap-east-1
  • ap-southeast-6 is inserted after ap-southeast-4

The LEGACY_COMMERCIAL_REGIONS env var is correctly left unchanged, as these new regions should use the per-region role ARN pattern rather than the shared legacy role.

LGTM.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 23, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.39%. Comparing base (09e6487) to head (7b6806b).
⚠️ Report is 566 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #1367       +/-   ##
=============================================
- Coverage     85.71%   69.39%   -16.33%     
- Complexity       19      704      +685     
=============================================
  Files             3       63       +60     
  Lines            49     3437     +3388     
  Branches          5      487      +482     
=============================================
+ Hits             42     2385     +2343     
- Misses            3      861      +858     
- Partials          4      191      +187     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@viw-test1 viw-test1 merged commit c6f5f4b into aws-observability:main Apr 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changelog doesn't need a CHANGELOG entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants