Add ap-east-2 and ap-southeast-6 to release build default regions#1367
Conversation
There was a problem hiding this comment.
Claude Code Review - PR #1367
Overall Assessment: No bugs or security issues found.
This PR adds two new AWS regions (ap-east-2 and ap-southeast-6) to the aws_region default input for the release build workflow. The changes are correctly placed:
- ap-east-2 is inserted after ap-east-1
- ap-southeast-6 is inserted after ap-southeast-4
The LEGACY_COMMERCIAL_REGIONS env var is correctly left unchanged, as these new regions should use the per-region role ARN pattern rather than the shared legacy role.
LGTM.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1367 +/- ##
=============================================
- Coverage 85.71% 69.39% -16.33%
- Complexity 19 704 +685
=============================================
Files 3 63 +60
Lines 49 3437 +3388
Branches 5 487 +482
=============================================
+ Hits 42 2385 +2343
- Misses 3 861 +858
- Partials 4 191 +187 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Issue #, if available:
Description of changes:
Add 2 new region to the build release
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.