ci: wire Service Events EC2 test into main-build

[vastin]

Summary

• Adds service-events-ec2 job to the E2E test workflow, calling java-ec2-service-events-test.yml@main from the test-framework repo.
• Runs after upload-main-build to validate Service Events telemetry (DeploymentEvent, IncidentSnapshot, FunctionCall) on every main-build.

Dependencies

• Requires aws-application-signals-test-framework PR #651 to merge first (the SE workflow must exist on main).

Test plan

• Merge test-framework PR Change dependency config in awsagentprovider #651
• Trigger main-build workflow and verify service-events-ec2 job passes

[github-actions]

Claude finished @vastin's task in 31s —— View job

---

Review

• Read prior reviews (none found)
• Reviewed PR diff
• Compared against existing patterns in the workflow file

Findings

No substantive issues. The 8-line addition is consistent with the established patterns in .github/workflows/application-signals-e2e-test.yml:

• needs: [ upload-main-build ] matches all other EC2 jobs (lines 52, 62, 72, 82, 92, 102, 109, 179, 217, 232, 262).
• @main ref, secrets: inherit, and the aws-region / caller-workflow-name inputs mirror the minimal job shape used by java-lambda-test (line 254) and others.
• The PR body correctly flags the dependency on test-framework PR Change dependency config in awsagentprovider #651 — without that merged, this job will fail to resolve the reusable workflow at @main. Also note that validate-all-tests-are-accounted-for (line 282) will start failing once Change dependency config in awsagentprovider #651 merges if this job were missing, so wiring it in here keeps that validator green.

LGTM pending the test-framework PR merge.
| Branch: serviceevents/wire-ec2-e2e

[github-actions]

Claude finished @vastin's task in 45s —— View job

---

Review

• Read prior reviews (no inline comments or formal reviews; only the prior summary in this thread)
• Reviewed PR diff (gh pr diff 1409)
• Compared against existing patterns in .github/workflows/application-signals-e2e-test.yml

Findings

No substantive issues. The 8-line addition is consistent with the established conventions in this workflow:

• needs: [ upload-main-build ] matches every other EC2 job in the file (e.g. lines 52, 62, 72, 82, 92, 102, 109, 179, 217, 232, 262 in the pre-change file). Correct dependency for an EC2 test that needs the uploaded ADOT image.
• @main ref, secrets: inherit, and the aws-region / caller-workflow-name inputs mirror the minimal job shape used by sibling reusable workflows (e.g. java-lambda-test at line 254).
• Placement just before validate-all-tests-are-accounted-for (line 282) is appropriate — that validator will fail once test-framework PR Change dependency config in awsagentprovider #651 lands unless this job is wired in (or added to its exclusions), so this PR keeps the validator green.

Caveats (already called out in the PR body)

• This PR depends on test-framework PR #651 being merged first. Until then, the @main ref will not resolve java-ec2-service-events-test.yml and this job will fail.
• Because the ref is @main (not pinned to a SHA), behavior of the new job will track whatever the test-framework main produces — same risk profile as every other job in this file, so not a new concern.

LGTM pending the test-framework PR merge.

| Branch: serviceevents/wire-ec2-e2e | |

[github-actions]

Claude finished @vastin's task in 23s —— View job

---

Review

• Read prior reviews (one formal APPROVED review by @mxiamxia; no inline comments)
• Reviewed PR diff (gh pr diff 1409)
• Checked dedup against prior Claude summaries on this thread

Findings

No new substantive issues since the prior reviews. The 8-line addition still matches the established conventions in .github/workflows/application-signals-e2e-test.yml:

• needs: [ upload-main-build ] — same dependency every other EC2 job uses.
• @main ref, secrets: inherit, and the aws-region / caller-workflow-name inputs — same minimal shape as sibling reusable-workflow jobs (e.g. java-lambda-test).
• Placement just before validate-all-tests-are-accounted-for keeps that validator green once test-framework PR Change dependency config in awsagentprovider #651 lands.

Caveats already called out in the PR body (dependency on test-framework PR #651; @main ref tracks upstream — same risk profile as every other job in the file) still apply, no change.

LGTM pending the test-framework PR merge.
| Branch: serviceevents/wire-ec2-e2e