Fix Claude Code review allowedTools to accept flags#734
Merged
syed-ahsan-ishtiaque merged 2 commits intomainfrom Apr 24, 2026
Merged
Fix Claude Code review allowedTools to accept flags#734syed-ahsan-ishtiaque merged 2 commits intomainfrom
syed-ahsan-ishtiaque merged 2 commits intomainfrom
Conversation
srprash
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*) to the Claude Code reviewallowedToolspatterns sogh pr diff NNNandgh pr view NNNcommands with flags (e.g.--json,--web) are still allowedBash(gh pr view 394)only matched the literal stringgh pr view 394and would deny any invocation with flags likegh pr view 394 --json number,title,..., causing Claude to burn through turns on repeated permission denials until hitting the 15-min timeoutSecurity
Trailing wildcard is still scoped to the current PR number via
${{ github.event.pull_request.number }}, so Claude cannot access other PRs. For exampleBash(gh pr view 394*)matchesgh pr view 394 --json ...but NOTgh pr view 391.Test plan