Skip to content

Commit de2100d

Browse files
committed
test(e2e-metrics): add null check for metrics response
- Add null check before accessing response.Metrics.Count to prevent potential NullReferenceException - Add explicit Assert.NotNull(response.Metrics) assertion before count validation - Improve test robustness by ensuring metrics collection is not null before operations - Prevents test failures due to unexpected null responses from CloudWatch API
1 parent 6451680 commit de2100d

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

  • libraries/tests/e2e/functions/core/metrics/Function/test/Function.Tests

libraries/tests/e2e/functions/core/metrics/Function/test/Function.Tests/FunctionTests.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ private async Task AssertCloudWatch()
142142
try
143143
{
144144
response = await cloudWatchClient.ListMetricsAsync(request);
145-
if (response.Metrics.Count > 6)
145+
if (response.Metrics != null && response.Metrics.Count > 6)
146146
{
147147
break;
148148
}
@@ -155,6 +155,7 @@ private async Task AssertCloudWatch()
155155
await Task.Delay(5000); // wait for 5 seconds before retrying
156156
}
157157

158+
Assert.NotNull(response.Metrics);
158159
Assert.Equal(7, response.Metrics.Count);
159160

160161
foreach (var metric in response.Metrics)

0 commit comments

Comments
 (0)