Refactoring tests

Author: leandrodamascena

aws_lambda_powertools/utilities/kafka/deserializer/deserializer.py

@@ -19,7 +19,7 @@ def _get_cache_key(schema_type: str | object, schema_value: Any) -> str:
 
     if isinstance(schema_value, str):
         # For string schemas like Avro, hash the content
-        schema_hash = hashlib.md5(schema_value.encode("utf-8")).hexdigest()
+        schema_hash = hashlib.md5(schema_value.encode("utf-8"), usedforsecurity=False).hexdigest()
     else:
         # For objects like Protobuf, use the object id
         schema_hash = str(id(schema_value))

aws_lambda_powertools/utilities/kafka/schema_config.py

@@ -64,21 +64,20 @@ def __init__(
         key_schema: str | None = None,
         key_output_serializer: Any | None = None,
     ):
-        # Validate schema requirements for value
-        if value_schema_type in ["AVRO", "PROTOBUF"] and value_schema is None:
-            raise KafkaConsumerMissingSchemaError(
-                f"value_schema must be provided when value_schema_type is {value_schema_type}",
-            )
-
-        # Validate schema requirements for key
-        if key_schema_type in ["AVRO", "PROTOBUF"] and key_schema is None:
-            raise KafkaConsumerMissingSchemaError(
-                f"value_schema must be provided when key_schema_type is {key_schema_type}",
-            )
+        # Validate schema requirements
+        self._validate_schema_requirements(value_schema_type, value_schema, "value")
+        self._validate_schema_requirements(key_schema_type, key_schema, "key")
 
         self.value_schema_type = value_schema_type
         self.value_schema = value_schema
         self.value_output_serializer = value_output_serializer
         self.key_schema_type = key_schema_type
         self.key_schema = key_schema
         self.key_output_serializer = key_output_serializer
+
+    def _validate_schema_requirements(self, schema_type: str | None, schema: str | None, prefix: str) -> None:
+        """Validate that schema is provided when required by schema_type."""
+        if schema_type in ["AVRO", "PROTOBUF"] and schema is None:
+            raise KafkaConsumerMissingSchemaError(
+                f"{prefix}_schema must be provided when {prefix}_schema_type is {schema_type}",
+            )

aws_lambda_powertools/utilities/kafka/serialization/custom_dict.py

@@ -12,4 +12,4 @@
 
 class CustomDictOutputSerializer(OutputSerializerBase):
     def serialize(self, data: dict[str, Any], output: type[T] | Callable | None = None) -> T | dict[str, Any]:
-        return data if output is None else output(data)
+        return data if output is None else output(data)  # type: ignore[call-arg]