Feat/agent plat tf#717
Open
zjaco13 wants to merge 11 commits into
Open
Conversation
allamand
reviewed
Jun 5, 2026
|
|
||
| # Also install the provider-family-aws (required dependency) | ||
| # Name must match crossplane-base chart (upbound-provider-family-aws) to avoid | ||
| # duplicate package lock entries when ArgoCD syncs the same chart later. |
Contributor
There was a problem hiding this comment.
we don't install crossplane with Gitops but with terraform ?
Contributor
Author
There was a problem hiding this comment.
crossplane needs to be there to create the pod identities that crossplane from gitops will use - willing to change this approach
Contributor
There was a problem hiding this comment.
yes seems chicken and eggs issue. in this case, why not juste create the roles with terraform ?
shapirov103
reviewed
Jun 30, 2026
shapirov103
left a comment
shapirov103
left a comment
Contributor
There was a problem hiding this comment.
Please resolve the conflicts and see my comment on ACM
| - KUBECONFIG={{.ROOT_DIR}}/private/hub-kubeconfig kubectl create namespace argocd --dry-run=client -o yaml | KUBECONFIG={{.ROOT_DIR}}/private/hub-kubeconfig kubectl apply -f - | ||
| - | | ||
| cat <<'EOF' | sed "s|CLUSTER_NAME|{{.HUB_CLUSTER_NAME}}|g; s|CLUSTER_ARN|{{.CLUSTER_ARN}}|g; s|REPO_URL|{{.REPO_URL}}|g; s|REPO_REVISION|{{.REPO_REVISION}}|g; s|REPO_BASEPATH|{{.REPO_BASEPATH}}|g; s|AWS_REGION|{{.AWS_REGION}}|g; s|AWS_ACCOUNT_ID|{{.AWS_ACCOUNT_ID}}|g; s|VPC_ID|{{.VPC_ID}}|g; s|SUBNET_IDS|{{.SUBNET_IDS}}|g; s|PRIVATE_SUBNET_IDS|{{.PRIVATE_SUBNET_IDS}}|g; s|CLUSTER_SG|{{.CLUSTER_SG}}|g; s|DOMAIN_NAME|{{.DOMAIN}}|g; s|INGRESS_NAME_VAL|{{.INGRESS_NAME}}|g; s|INGRESS_SG_VAL|{{.INGRESS_SECURITY_GROUPS}}|g; s|RESOURCE_PREFIX_VAL|{{.RESOURCE_PREFIX}}|g" | KUBECONFIG={{.ROOT_DIR}}/private/hub-kubeconfig kubectl apply -f - | ||
| cat <<'EOF' | sed "s|CLUSTER_NAME|{{.HUB_CLUSTER_NAME}}|g; s|CLUSTER_ARN|{{.CLUSTER_ARN}}|g; s|REPO_URL|{{.REPO_URL}}|g; s|REPO_REVISION|{{.REPO_REVISION}}|g; s|REPO_BASEPATH|{{.REPO_BASEPATH}}|g; s|AWS_REGION|{{.AWS_REGION}}|g; s|AWS_ACCOUNT_ID|{{.AWS_ACCOUNT_ID}}|g; s|VPC_ID|{{.VPC_ID}}|g; s|SUBNET_IDS|{{.SUBNET_IDS}}|g; s|PRIVATE_SUBNET_IDS|{{.PRIVATE_SUBNET_IDS}}|g; s|CLUSTER_SG|{{.CLUSTER_SG}}|g; s|DOMAIN_NAME|{{.DOMAIN}}|g; s|INGRESS_NAME_VAL|{{.INGRESS_NAME}}|g; s|INGRESS_SG_VAL|{{.INGRESS_SECURITY_GROUPS}}|g; s|RESOURCE_PREFIX_VAL|{{.RESOURCE_PREFIX}}|g; s|ACM_CERT_ARN|{{.ACM_CERTIFICATE_ARN}}|g" | KUBECONFIG={{.ROOT_DIR}}/private/hub-kubeconfig kubectl apply -f - |
Contributor
There was a problem hiding this comment.
ACM is optional - are we accounting for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.