Merged
Conversation
…pace in shared namespace definition
…ce to UnicornApprovalsNamespace across multiple templates
…als in configuration and code files
|
No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure. |
github-actions
Bot
added
do-not-merge
adrianjhunter
removed
the
need-issue
adrianjhunter
requested changes
Jul 7, 2025
Contributor
adrianjhunter
left a comment
adrianjhunter
left a comment
There was a problem hiding this comment.
Please update references to the Properties service in:
/README.md
/unicorn_contracts/README.md
/unicorn_approvals/README.md
/unicorn_web/README.md
/docs/architecture.png
adrianjhunter
added
documentation
…vice, including event handler, approval sync, and status checker
… actions/github-script@v7
…ndling publication approval requests and events
…fig.yaml for stack name
|
undefined No related issues found. Please ensure 'pending-release' label is applied before releasing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This pull request refactors the Unicorn Properties service into Unicorn Approvals service, updating the namespace and service naming throughout the codebase. The main changes include:
Unicorn.PropertiestoUnicorn.Approvalsthroughout the codebaseUnicornPropertiesNamespacetoUnicornApprovalsNamespaceUnicornPropertiesEventBustoUnicornApprovalsEventBusUser experience
Before: The service was named "Unicorn Properties" which could be confusing as it handled approval workflows rather than property management directly.
After: The service is now named "Unicorn Approvals" which more accurately reflects its purpose of handling approval workflows for contracts and properties. This provides better clarity for developers and users about the service's actual functionality.
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.