Enable DEFAULT_API_KEYS via Docker Environment Variable#138
Closed
CajuCLC wants to merge 1 commit into
Closed
Conversation
changqian9
approved these changes
May 13, 2025
fabianx-ai
approved these changes
Jun 6, 2025
Contributor
fabianx-ai
left a comment
There was a problem hiding this comment.
Peer-Review: Looks great to me!
Member
|
It won't support the hardcoded key. Use the env variables for secrets or api key. bedrock-access-gateway/src/api/auth.py Lines 18 to 30 in b4800c5 |
Author
This is not for the secrets or api key. This is for the PASSWORD. But it seems someone removed it on another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Issue 137: Pass DEFAULT_API_KEYS via Docker env
Description of changes:
api/settings.pyto readDEFAULT_API_KEYSfrom the environment variable.DEFAULT_API_KEYSdynamically through Docker, providing enhanced flexibility for authentication configuration.Example Docker command to run with custom API key:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.