feat(git hooks): introduce husky#1018
Merged
Merged
Conversation
tbrand
reviewed
Apr 21, 2025
Contributor
tbrand
left a comment
There was a problem hiding this comment.
Thank you very much. I agree with introducing Husky, but I think it should be introduced more carefully. There are developers of various levels in GenU.
In the documentation, all mentions of npm run lint have been removed, but please explain this more carefully here.
Specifically, I think we need explanations like "npm run lint is now executed when git commit is run, and if it fails, the commit will result in an error like xxx."
892dfb2 to
2ed9247
Compare
tbrand
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
In this PR, by introducing
husky, developers can notice that they forgot to runnpm run lintat the time of commit.Checklist
npm run lintnpm run cdk:testand if there are snapshot differences, executenpm run cdk:test:update-snapshotto update snapshotsRelated Issues
N/A