Skip to content

Commit 8df5d49

Browse files
committed
Fixed PR comments
1 parent e745f11 commit 8df5d49

7 files changed

Lines changed: 67 additions & 32 deletions

File tree

samples/spring-ai-agent/pom.xml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
<java.version>21</java.version>
3131
<spring-ai.version>1.0.0</spring-ai.version>
3232
<postgresql.version>42.7.5</postgresql.version>
33-
<lombok.version>1.18.38</lombok.version>
3433
<jib-maven-plugin.version>3.4.5</jib-maven-plugin.version>
3534
</properties>
3635
<dependencies>
@@ -57,12 +56,6 @@
5756
<groupId>org.liquibase</groupId>
5857
<artifactId>liquibase-core</artifactId>
5958
</dependency>
60-
<dependency>
61-
<groupId>org.projectlombok</groupId>
62-
<artifactId>lombok</artifactId>
63-
<version>${lombok.version}</version>
64-
<scope>provided</scope>
65-
</dependency>
6659

6760
<dependency>
6861
<groupId>org.springframework.boot</groupId>

samples/spring-ai-agent/src/main/java/com/aws/workshop/ai/agent/controller/ExternalizedMemoryAgentController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public InputStream chatStream(@RequestBody String prompt) {
4949

5050
@PostMapping("/model")
5151
public void updateModel(@RequestParam String model) {
52-
ChatOptions chatOptions = ChatOptions.builder()
52+
var chatOptions = ChatOptions.builder()
5353
.model(model).build();
5454
chatClient = chatClientBuilder
5555
.defaultOptions(chatOptions).build();

samples/spring-ai-agent/src/main/java/com/aws/workshop/ai/agent/controller/MemoryAgentController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public InputStream chatStream(@RequestBody String prompt) {
5050

5151
@PostMapping("/model")
5252
public void updateModel(@RequestParam String model) {
53-
ChatOptions chatOptions = ChatOptions.builder()
53+
var chatOptions = ChatOptions.builder()
5454
.model(model).build();
5555
chatClient = chatClientBuilder
5656
.defaultOptions(chatOptions).build();

samples/spring-ai-agent/src/main/java/com/aws/workshop/ai/agent/controller/StatelessAgentController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public InputStream chatStream(@RequestBody String prompt) {
3838

3939
@PostMapping("/model")
4040
public void updateModel(@RequestParam String model) {
41-
ChatOptions chatOptions = ChatOptions.builder()
41+
var chatOptions = ChatOptions.builder()
4242
.model(model).build();
4343
chatClient = chatClientBuilder
4444
.defaultOptions(chatOptions).build();
Lines changed: 57 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,72 @@
11
package com.aws.workshop.ai.agent.memory;
22

33
import jakarta.persistence.*;
4-
import lombok.AllArgsConstructor;
5-
import lombok.Builder;
6-
import lombok.Data;
7-
import lombok.NoArgsConstructor;
84

95
import java.time.Instant;
106

117
@Entity
128
@Table(name = "chat_messages")
13-
@Data
14-
@NoArgsConstructor
15-
@AllArgsConstructor
16-
@Builder
9+
@SuppressWarnings("unused")
1710
public class ChatMessageEntity {
11+
@Id
12+
@GeneratedValue(strategy = GenerationType.IDENTITY)
13+
private Long id;
1814

19-
@Id
20-
@GeneratedValue(strategy = GenerationType.IDENTITY)
21-
private Long id;
15+
private String conversationId;
2216

23-
private String conversationId;
17+
private String text;
2418

25-
private String text;
19+
private Instant timestamp;
2620

27-
private Instant timestamp;
21+
private String type;
2822

29-
private String type;
23+
public ChatMessageEntity() {
24+
}
25+
26+
public ChatMessageEntity(String conversationId, String text, Instant timestamp, String type) {
27+
this.conversationId = conversationId;
28+
this.text = text;
29+
this.timestamp = timestamp;
30+
this.type = type;
31+
}
32+
33+
public Long getId() {
34+
return id;
35+
}
36+
37+
public void setId(Long id) {
38+
this.id = id;
39+
}
40+
41+
public String getConversationId() {
42+
return conversationId;
43+
}
44+
45+
public void setConversationId(String conversationId) {
46+
this.conversationId = conversationId;
47+
}
48+
49+
public String getText() {
50+
return text;
51+
}
52+
53+
public void setText(String text) {
54+
this.text = text;
55+
}
56+
57+
public Instant getTimestamp() {
58+
return timestamp;
59+
}
60+
61+
public void setTimestamp(Instant timestamp) {
62+
this.timestamp = timestamp;
63+
}
64+
65+
public String getType() {
66+
return type;
67+
}
68+
69+
public void setType(String type) {
70+
this.type = type;
71+
}
3072
}

samples/spring-ai-agent/src/main/java/com/aws/workshop/ai/agent/memory/ExternalChatMemoryRepository.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,12 @@ public void saveAll(@NonNull String conversationId, List<Message> messages) {
4444
List<ChatMessageEntity> entities = messages.stream()
4545
// Currently only memory for user messages is supported
4646
.filter(msg -> MessageType.USER == msg.getMessageType())
47-
.map(msg -> ChatMessageEntity.builder()
48-
.conversationId(conversationId)
49-
.text(msg.getText())
50-
.type(msg.getMessageType().name())
51-
.timestamp(Instant.now())
52-
.build()).toList();
47+
.map(msg -> new ChatMessageEntity(
48+
conversationId,
49+
msg.getText(),
50+
Instant.now(),
51+
msg.getMessageType().name())
52+
).toList();
5353

5454
jpaRepository.saveAll(entities);
5555
}

samples/spring-ai-agent/src/main/resources/db/changelog/changelog-master.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
databaseChangeLog:
22
- changeSet:
33
id: create-chat-messages-table
4-
author: andrei.shakirin
4+
author: spring-ai.workshop.team.aws
55
preConditions:
66
- onFail: MARK_RAN
77
- not:

0 commit comments

Comments
 (0)