refactor(perf-platform): rename ECS_FARGATE to ECS platform enum

Author: Yuriy Bezsonov

apps/perf-analyzer/src/main/java/com/example/perf/analyzer/AnalysisService.java

@@ -214,7 +214,7 @@ record WorkloadMetadata(String githubRepo, String githubPath) {
     private LocatedCollector locateCollector(AnalysisRequest request) {
         return switch (request.platform()) {
             case EKS -> locateCollectorEks(request);
-            case ECS_FARGATE -> locateCollectorEcs(request);
+            case ECS -> locateCollectorEcs(request);
         };
     }
 
@@ -378,16 +378,16 @@ private static String shortRandom() {
      * queries must use the same suffix or Pyroscope returns no data.
      */
     private static String pyroscopeServiceName(AnalysisRequest request) {
-        var suffix = request.platform() == Platform.ECS_FARGATE ? "ecs" : "eks";
+        var suffix = request.platform() == Platform.ECS ? "ecs" : "eks";
         return request.service() + "-" + suffix;
     }
 
     // === Domain types ===
 
     public enum Platform {
-        EKS, ECS_FARGATE;
+        EKS, ECS;
 
-        /** Case-insensitive deserialization: accepts "eks"/"EKS" and "ecs-fargate"/"ECS_FARGATE". */
+        /** Case-insensitive deserialization: accepts "eks"/"EKS" and "ecs"/"ECS". */
         @com.fasterxml.jackson.annotation.JsonCreator
         public static Platform fromJson(String value) {
             if (value == null) return null;
@@ -407,7 +407,7 @@ public enum DumpKind {
     public record AnalysisRequest(
         String service, Platform platform, String pod, String task, String reason, TriggerSource source
     ) {
-        public String target() { return platform == Platform.ECS_FARGATE ? task : pod; }
+        public String target() { return platform == Platform.ECS ? task : pod; }
     }
 
     public record AnalysisContext(

apps/perf-analyzer/src/main/java/com/example/perf/analyzer/AnalyzeController.java

@@ -76,8 +76,8 @@ private static void validateTarget(AnalyzeRequest r) {
         if (r.platform() == AnalysisService.Platform.EKS && !hasPod) {
             throw new IllegalArgumentException("pod is required for platform=eks");
         }
-        if (r.platform() == AnalysisService.Platform.ECS_FARGATE && !hasTask) {
-            throw new IllegalArgumentException("task is required for platform=ecs-fargate");
+        if (r.platform() == AnalysisService.Platform.ECS && !hasTask) {
+            throw new IllegalArgumentException("task is required for platform=ecs");
         }
     }
 
@@ -102,7 +102,7 @@ private AnalysisService.AnalysisRequest toRequest(Map<String, String> labels) {
             platform = AnalysisService.Platform.EKS;
             workload = serviceLabel.substring(0, serviceLabel.length() - "-eks".length());
         } else if (serviceLabel.endsWith("-ecs")) {
-            platform = AnalysisService.Platform.ECS_FARGATE;
+            platform = AnalysisService.Platform.ECS;
             workload = serviceLabel.substring(0, serviceLabel.length() - "-ecs".length());
         } else {
             // Unsuffixed — honour explicit platform label if present.

apps/perf-collector/README.md

@@ -1,6 +1,6 @@
 # perf-collector
 
-Runs alongside target JVMs on Amazon EKS (DaemonSet) and Amazon ECS Fargate
+Runs alongside target JVMs on Amazon EKS (DaemonSet) and Amazon ECS
 (sidecar). Discovers JVMs whose owning workload is opted in with the
 `perf-profile/service` label (EKS) or tag (ECS). Attaches async-profiler
 for continuous Pyroscope push. Serves `POST /dump` to capture on-demand
@@ -58,15 +58,15 @@ Multi-arch (`linux/amd64` + `linux/arm64`), Amazon Corretto 25 JRE base.
 | `AWS_REGION` | yes | AWS Region for the S3 SDK client. |
 | `AWS_S3_BUCKET` | yes | Workshop bucket (SSM `workshop-bucket-name`). |
 | `PYROSCOPE_URL` | yes | `http://pyroscope.monitoring:4040` on EKS; internal NLB DNS on ECS. |
-| `PERF_COLLECTOR_PLATFORM` | yes | `eks` or `ecs_fargate`. Drives which `TargetResolver` bean wakes up. |
+| `PERF_COLLECTOR_PLATFORM` | yes | `eks` or `ecs`. Drives which `TargetResolver` bean wakes up. |
 | `NODE_NAME` | EKS only | From Downward API (`spec.nodeName`). Limits discovery to pods on own node. |
 
 ## Label / tag contract
 
 | Platform | Opt-in marker | Service name source | Version source |
 |----------|---------------|---------------------|----------------|
 | EKS | pod label `perf-profile/service=<name>` | label value | `app.kubernetes.io/version` or container image tag |
-| ECS Fargate | task tag `perf-profile:service=<name>` | tag value | app container image tag |
+| ECS | task tag `perf-profile:service=<name>` | tag value | app container image tag |
 
 Missing marker → workload is ignored entirely. No profiler attach, no
 Pyroscope samples, no footprint.
@@ -78,6 +78,6 @@ manifests, Pod Identity binding, and capability requirements.
 Key invariants:
 
 - EKS DaemonSet: `hostPID: true` + `SYS_PTRACE` capability.
-- ECS Fargate task: `pidMode: task` + sidecar `linuxParameters.capabilities.add: ["SYS_PTRACE"]`.
+- ECS task: `pidMode: task` + sidecar `linuxParameters.capabilities.add: ["SYS_PTRACE"]`.
 - IAM: `perf-collector-eks-pod-role` (EKS) or `perf-collector-ecs-task-role`
   (ECS), both provisioned by the `PerfPlatform.java` CDK construct.

apps/perf-collector/pom.xml

@@ -13,7 +13,7 @@
     <artifactId>perf-collector</artifactId>
     <version>1.0.0</version>
     <name>perf-collector</name>
-    <description>Agentic Performance Platform collector (DaemonSet on EKS, sidecar on ECS Fargate)</description>
+    <description>Agentic Performance Platform collector (DaemonSet on EKS, sidecar on ECS)</description>
 
     <properties>
         <java.version>25</java.version>
@@ -59,7 +59,7 @@
             <groupId>software.amazon.awssdk</groupId>
             <artifactId>s3</artifactId>
         </dependency>
-        <!-- ECS client for DescribeTasks with tag inclusion. Fargate task metadata
+        <!-- ECS client for DescribeTasks with tag inclusion. The task metadata
              endpoint does not expose task tags, so we call the ECS API directly. -->
         <dependency>
             <groupId>software.amazon.awssdk</groupId>

apps/perf-collector/src/main/java/com/example/perf/collector/Application.java

@@ -24,7 +24,7 @@
  * node, attaches async-profiler for continuous Pyroscope push, serves /dump
  * on demand for JFR and Thread.print.
  *
- * On Amazon ECS Fargate: sidecar, pidMode=task, SYS_PTRACE. Sees sibling
+ * On Amazon ECS: sidecar, pidMode=task, SYS_PTRACE. Sees sibling
  * Java container's JVM via /proc; same mechanics.
  *
  * AWS and Kubernetes client beans live here so the rest of the package stays
@@ -44,16 +44,17 @@ S3Client s3Client(@Value("${AWS_REGION:us-east-1}") String region) {
         return S3Client.builder().region(Region.of(region)).build();
     }
 
-    /** ECS client — only on Fargate. The Fargate task-metadata endpoint does
-     *  not include task tags, so the resolver reads them via ecs:DescribeTasks. */
+    /** ECS client — only when the collector runs as an ECS sidecar. The task
+     *  metadata endpoint does not include task tags, so the resolver reads
+     *  them via ecs:DescribeTasks. */
     @Bean
     @ConditionalOnProperty(prefix = "perf.collector", name = "platform",
-        havingValue = "ecs_fargate")
+        havingValue = "ecs")
     EcsClient ecsClient(@Value("${AWS_REGION:us-east-1}") String region) {
         return EcsClient.builder().region(Region.of(region)).build();
     }
 
-    /** Kubernetes client — only on EKS. The ECS Fargate resolver uses no K8s API. */
+    /** Kubernetes client — only on EKS. The ECS resolver uses no K8s API. */
     @Bean
     @ConditionalOnProperty(prefix = "perf.collector", name = "platform",
         havingValue = "eks", matchIfMissing = true)

apps/perf-collector/src/main/java/com/example/perf/collector/CollectorController.java

@@ -64,7 +64,7 @@ public static DumpTarget of(
         }
 
         public String id() {
-            return platform == Platform.ECS_FARGATE ? task : pod;
+            return platform == Platform.ECS ? task : pod;
         }
 
         private static Platform parsePlatform(String s) {

apps/perf-collector/src/main/java/com/example/perf/collector/CollectorProperties.java

@@ -24,7 +24,7 @@ public record CollectorProperties(
     String hostLibPath
 ) {
 
-    public enum Platform { EKS, ECS_FARGATE }
+    public enum Platform { EKS, ECS }
 
     public enum DumpKind {
         JFR("jfr"),

apps/perf-collector/src/main/java/com/example/perf/collector/Profiler.java

@@ -262,7 +262,7 @@ private void pushFile(Path file, long pid, TargetJvm jvm) throws IOException, In
         // underlying workload (what the user set with perf-profile/service) is
         // published as a `workload` label for cross-platform pivoting.
         var platformTag = jvm.platform().name().toLowerCase().replace('_', '-');
-        var platformSuffix = jvm.platform() == CollectorProperties.Platform.ECS_FARGATE
+        var platformSuffix = jvm.platform() == CollectorProperties.Platform.ECS
             ? "ecs"
             : "eks";
         var pyroscopeServiceName = jvm.serviceName() + "-" + platformSuffix;

apps/perf-collector/src/main/java/com/example/perf/collector/TargetResolver.java

@@ -155,10 +155,10 @@ private static String stripRuntimePrefix(String containerId) {
         }
     }
 
-    /** ECS Fargate sidecar implementation. Reads task metadata endpoint. */
+    /** ECS sidecar implementation. Reads task metadata endpoint. */
     @Component
     @ConditionalOnProperty(prefix = "perf.collector", name = "platform",
-        havingValue = "ecs_fargate")
+        havingValue = "ecs")
     final class Ecs implements TargetResolver {
 
         private static final Logger logger = LoggerFactory.getLogger(Ecs.class);
@@ -201,7 +201,7 @@ public List<TargetJvm> resolve() {
                 if (javaPids.isEmpty()) return List.of();
 
                 var pid = javaPids.getFirst();  // one sibling Java container per task
-                var t = new TargetJvm(pid, serviceName, version, taskId, Platform.ECS_FARGATE);
+                var t = new TargetJvm(pid, serviceName, version, taskId, Platform.ECS);
                 byTaskId.clear();
                 byTaskId.put(taskId, t);
                 logger.info("ECS discovery: taskId={} service={} version={} pid={}",

apps/perf-collector/src/main/resources/application.yaml

@@ -19,7 +19,7 @@ perf:
     discovery-interval-seconds: 30
     # Node identity (EKS DaemonSet): kubelet downward API.
     node-name: ${NODE_NAME:}
-    # Platform selector (set per deployment: eks | ecs_fargate).
+    # Platform selector (set per deployment: eks | ecs).
     platform: ${PERF_COLLECTOR_PLATFORM:eks}
     async-profiler-lib: /opt/perf-collector/async-profiler/libasyncProfiler.so
     jattach-binary: /opt/perf-collector/bin/jattach