Skip to content

Commit 0b80c85

Browse files
bgagentclaude
andcommitted
docs(review_prs): fix Stage-3 cross-ref and require rationale in result schema (#621)
Address two review nits on the /review_prs sketch: - The agent-prompt parenthetical cited `review_pr` for the submission mechanism, but `review_pr.md` tops out at Stage 5 "Present to User" and documents no `gh api` path. The POST-to-/reviews mechanism lives in this file's own Stage 3 — re-anchor the cross-reference there. - Add `rationale` to the RESULT schema's `required` list so an agent can no longer satisfy the schema with an empty rationale, which the prose (L135-136) and the Stage-3 report table both assume is present. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent d0bdab6 commit 0b80c85

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

.abca/commands/review_prs.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ export const meta = {
145145
description: 'Review a set of PRs, one review_pr per PR, return compact verdicts',
146146
phases: [{ title: 'Review' }],
147147
}
148-
const RESULT = { type: 'object', required: ['number', 'verdict', 'reviewUrl'], properties: {
148+
const RESULT = { type: 'object', required: ['number', 'verdict', 'rationale', 'reviewUrl'], properties: {
149149
number: { type: 'number' },
150150
verdict: { enum: ['APPROVE', 'COMMENT', 'REQUEST_CHANGES'] },
151151
rationale: { type: 'string' },
@@ -157,7 +157,7 @@ const results = await parallel(args.map((pr) => () =>
157157
`suggestions. Worktree: ${pr.worktreePath}. Diff: ${pr.diffPath}. commit_id: ${pr.headSha}. ` +
158158
`Base: ${pr.baseRef}${pr.baseRef !== 'main' ? ' (STACKED — diff is vs the base branch)' : ''}. ` +
159159
`Governance: gate is an approved backing issue; a pr/* branch is a waived nit. Read existing ` +
160-
`review threads first and verify prior blocking claims. Submit via gh api (see review_pr).`,
160+
`review threads first and verify prior blocking claims. Submit via gh api (see Stage 3).`,
161161
{ label: `review:#${pr.number}`, phase: 'Review', schema: RESULT },
162162
)))
163163
return results.filter(Boolean)

0 commit comments

Comments
 (0)