Skip to content

Commit 3adb6e2

Browse files
fix(docs): add GitHubTokenSecret to SecretsManager resource scope
CDK generates the GitHub token secret with construct ID hash (GitHubTokenSecret09BC4210-*), not the backgroundagent- prefix. Add this pattern to the SecretsManager statement Resource list. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent abe2a90 commit 3adb6e2

2 files changed

Lines changed: 8 additions & 2 deletions

File tree

docs/design/DEPLOYMENT_ROLES.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,10 @@ DynamoDB tables, Lambda functions, API Gateway, Cognito, WAFv2, EventBridge, and
415415
"secretsmanager:PutResourcePolicy",
416416
"secretsmanager:DeleteResourcePolicy"
417417
],
418-
"Resource": "arn:aws:secretsmanager:*:*:secret:backgroundagent-*"
418+
"Resource": [
419+
"arn:aws:secretsmanager:*:*:secret:backgroundagent-*",
420+
"arn:aws:secretsmanager:*:*:secret:GitHubTokenSecret*"
421+
]
419422
},
420423
{
421424
"Sid": "SecretsManagerAccountLevel",

docs/src/content/docs/architecture/Deployment-roles.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -419,7 +419,10 @@ DynamoDB tables, Lambda functions, API Gateway, Cognito, WAFv2, EventBridge, and
419419
"secretsmanager:PutResourcePolicy",
420420
"secretsmanager:DeleteResourcePolicy"
421421
],
422-
"Resource": "arn:aws:secretsmanager:*:*:secret:backgroundagent-*"
422+
"Resource": [
423+
"arn:aws:secretsmanager:*:*:secret:backgroundagent-*",
424+
"arn:aws:secretsmanager:*:*:secret:GitHubTokenSecret*"
425+
]
423426
},
424427
{
425428
"Sid": "SecretsManagerAccountLevel",

0 commit comments

Comments
 (0)