You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Resolve lockfile conflicts and fix post-merge build: pin Astro MDX/markdown-remark
via yarn resolutions and ignore ty deprecated warnings for asyncio 3.14 APIs.
Co-authored-by: Cursor <cursoragent@cursor.com>
IDs, cdk-nag clean. Watch for cost and operational footguns.
76
98
-**Tests** — Are unit tests added/updated under the matching `*/test/` tree? Do they cover the
77
99
new behavior and failure paths, not just the happy path?
100
+
-**Test performance (CDK synth)** — New/changed CDK tests must not re-enable Lambda bundling at
101
+
synth or synthesize the same stack repeatedly. `cdk/` disables bundling globally via
102
+
`test/setup/disable-bundling.ts` (~15× faster synth); flag any test that turns
103
+
`aws:cdk:bundling-stacks` back on (only valid via `postCliContext`, not constructor
104
+
`context` — the env var overwrites the latter) without asserting on a bundled asset, or
105
+
that calls `new App()` + `Template.fromStack()` per-test instead of once in `beforeAll`.
106
+
See #366.
78
107
-**Routing** — Changes should land in the right package per the AGENTS.md routing table
79
108
(agent runtime in `agent/`, API/Lambdas in `cdk/`, CLI in `cli/`).
80
109
@@ -110,12 +139,7 @@ Documentation drift is a blocking concern on this repo. Check:
110
139
-**Never edit `docs/src/content/docs/` by hand** — it is generated.
111
140
-**AGENTS.md / README / package docs** — Updated if the developer flow, routing, or commands
112
141
changed.
113
-
-**Roadmap reflects the change** — Confirm whatever this PR fixes or delivers is marked or
114
-
updated in [docs/guides/ROADMAP.md](../../docs/guides/ROADMAP.md) (e.g. item checked off,
115
-
status moved, or a new entry added). If the change advances or completes a roadmap item and
116
-
the PR leaves the roadmap untouched, flag it. Remember the roadmap is a synced source — after
117
-
editing `docs/guides/ROADMAP.md`, the Starlight mirror `docs/src/content/docs/roadmap/Roadmap.md`
118
-
must be regenerated via `mise //docs:sync`.
142
+
-**Issue tracking reflects the change** — Confirm whatever this PR fixes or delivers is filed or updated as a [GitHub issue](https://github.com/aws-samples/sample-autonomous-cloud-coding-agents/issues) with an appropriate priority label (`P0`, `P1`, etc.). If the change completes planned work and no issue exists, flag it.
119
143
120
144
### Stage 5: Present to User
121
145
@@ -126,7 +150,8 @@ Summarize as a principal architect would in a PR review. Structure the output:
126
150
3.**Blocking issues** — Numbered, each with `file:line`, the risk, and a suggested fix.
Copy file name to clipboardExpand all lines: .github/ISSUE_TEMPLATE/feature_request.yml
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -8,7 +8,7 @@ body:
8
8
- type: markdown
9
9
attributes:
10
10
value: |
11
-
Thanks for suggesting an idea. You may want to check the [ROADMAP](https://github.com/krokoko/bgagent/blob/main/docs/guides/ROADMAP.md) and [design docs](https://github.com/krokoko/bgagent/tree/main/docs/design) to see if something similar is already planned.
11
+
Thanks for suggesting an idea. You may want to check [open GitHub issues](https://github.com/aws-samples/sample-autonomous-cloud-coding-agents/issues) and [design docs](https://github.com/aws-samples/sample-autonomous-cloud-coding-agents/tree/main/docs/design) to see if something similar is already planned.
Copy file name to clipboardExpand all lines: .github/ISSUE_TEMPLATE/rfc.yml
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -8,7 +8,7 @@ body:
8
8
- type: markdown
9
9
attributes:
10
10
value: |
11
-
Use this template for significant feature or design proposals. Please add as much detail as possible. See the [ROADMAP](https://github.com/krokoko/bgagent/blob/main/docs/guides/ROADMAP.md) and [design docs](https://github.com/krokoko/bgagent/tree/main/docs/design) for existing direction; your RFC should align or explain divergence.
11
+
Use this template for significant feature or design proposals. Please add as much detail as possible. See [open GitHub issues](https://github.com/aws-samples/sample-autonomous-cloud-coding-agents/issues) and [design docs](https://github.com/aws-samples/sample-autonomous-cloud-coding-agents/tree/main/docs/design) for existing direction; your RFC should align or explain divergence.
echo "::notice title=knip ratchet::Dead-code count is at or below baseline."
53
+
else
54
+
echo "::warning title=knip ratchet::Dead-code count increased above the baseline (knip-baseline.json). Run 'yarn knip' locally and remove the new dead code, or suppress a false positive in knip.json."
55
+
fi
56
+
57
+
- name: Python dead-code scan (vulture, advisory)
58
+
continue-on-error: true
59
+
run: |
60
+
if mise //agent:lint:deadcode; then
61
+
echo "::notice title=vulture::No Python dead code above the confidence threshold."
62
+
else
63
+
echo "::warning title=vulture::vulture found unused Python code. Remove it, or add an intentional keep to agent/.vulture_allowlist.py."
0 commit comments