Skip to content

Commit c566444

Browse files
authored
Merge branch 'main' into feat/117-dlq-cloudwatch-alarms
2 parents 3291bbc + bc94972 commit c566444

59 files changed

Lines changed: 1486 additions & 1376 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.abca/commands/review_pr.md

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,24 @@ Then apply principal-architect judgment over the diff:
7878
- **Routing** — Changes should land in the right package per the AGENTS.md routing table
7979
(agent runtime in `agent/`, API/Lambdas in `cdk/`, CLI in `cli/`).
8080

81+
**Human review heuristics (non-automatable)** — After automated agents, apply these four
82+
dimensions. They are where agent output often looks plausible but isn't. Flag blocking issues when
83+
a dimension is clearly violated:
84+
85+
- **Proportionality** — Does complexity match the problem? (new abstraction/factory/"engine"
86+
for a one-off → AI002/AI003; files >800 lines — is size essential or accreted?)
87+
- **Coherence** — Does it belong here? Same concept = same term across the repo? Parallel
88+
structure with real substance, not copy-paste boilerplate (AI006)?
89+
- **Clarity** — Do names communicate intent? Does error handling surface failures or hide
90+
them behind plausible defaults (AI004)? Magic values that should live in
91+
`contracts/constants.json` (AI007)?
92+
- **Appropriateness** — Maintainable by this team? Integration code verified against *real*
93+
API behavior, not only self-written mocks (AI001)? Tests assert what code *should* do,
94+
not merely what it *does* (AI005)?
95+
96+
Include a **Human heuristics** subsection in Stage 5 output: one bullet per dimension
97+
(pass or concern with `file:line` when applicable).
98+
8199
### Stage 4: Documentation — Did We Update It Where Needed?
82100

83101
Documentation drift is a blocking concern on this repo. Check:
@@ -112,5 +130,7 @@ Summarize as a principal architect would in a PR review. Structure the output:
112130
7. **Review agents run** — List each plugin/agent you invoked (Stage 3) and, for any in-scope
113131
agent you omitted, the one-line reason. This section is required — its absence means the
114132
mandatory plugin step was skipped.
133+
8. **Human heuristics** — Proportionality, Coherence, Clarity, Appropriateness (pass or concern
134+
per dimension; cite `file:line` when not pass).
115135

116136
Be specific and actionable. Prefer concrete diffs over vague advice.

.github/workflows/build.yml

Lines changed: 115 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)