Skip to content

Commit d0bdab6

Browse files
bgagentclaude
andcommitted
fix(review_prs): cite the real pr_review system-prompt binding, not loader.py (review)
The Execution-context section credited `agent/src/workflow/loader.py` with binding the `pr_review` system prompt, but loader.py has no prompt logic — its `coding/pr-review-v1 → pr_review` entry is the Cedar *principal* (an audit/identity tag; read-only enforcement keys off `context.read_only` since #248 Phase 2a, per the file's own comment). The real system-prompt binding is `PR_REVIEW_WORKFLOW` in `agent/src/prompts/pr_review.py`, selected by `get_system_prompt` in `agent/src/prompts/__init__.py:28`. The claim's conclusion (no slash-command path into the headless review workflow) was correct, but the cited file would mislead a maintainer who opened loader.py to verify it — the same trust-eroding mis-citation class as the earlier allow-list/deny-list mix-up. Now attributes the prompt to the right files and notes loader.py's entry is the principal tag. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 8b5a52c commit d0bdab6

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

.abca/commands/review_prs.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,11 @@ core tool, `Workflow`, is unavailable to headless tasks by construction:
4747
`disallowed_tools` block, not mere obscurity, is the guarantee: even though the file is on disk and
4848
reachable on that path, the tool it calls is off the surface.
4949
- The read-only review workflow (`coding/pr-review-v1`) cannot be steered into `/review_prs`: it is
50-
bound to the `pr_review` system prompt (`agent/src/workflow/loader.py`) and drives the agent
51-
through that fixed prompt — there is no "invoke a slash command" path, and `Workflow` is
52-
deny-listed regardless.
50+
bound to a fixed `pr_review` system prompt (`PR_REVIEW_WORKFLOW` in `agent/src/prompts/pr_review.py`,
51+
selected by `get_system_prompt` in `agent/src/prompts/__init__.py`) that drives the agent through
52+
fixed steps — there is no "invoke a slash command" path, and `Workflow` is deny-listed regardless.
53+
(The `coding/pr-review-v1 → pr_review` entry in `agent/src/workflow/loader.py` is the Cedar
54+
*principal* audit tag, not the prompt binding.)
5355

5456
In short: operators run `/review_prs`; the ABCA runtime never does, and structurally cannot.
5557

0 commit comments

Comments
 (0)