fix: pass useNatInstance prop to MainStack#71
Merged
tmokmss merged 1 commit intoaws-samples:mainfrom Dec 7, 2025
Merged
Conversation
Contributor
|
Thanks! |
This was referenced Mar 18, 2026
konokenj
pushed a commit
that referenced
this pull request
Mar 18, 2026
🤖 I have created a release *beep* *boop* --- ## 2.0.0 (2026-03-18) ### Features * invalidate cloudfront caches when lambda configuration changes ([#63](#63)) ([b76d122](b76d122)) ### Bug Fixes * pass useNatInstance prop to MainStack ([#71](#71)) ([23c9e31](23c9e31)) * Workflow does not contain permissions ([#59](#59)) ([34be1de](34be1de)) * Workflow does not contain permissions ([#60](#60)) ([6fb8901](6fb8901)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
useNatInstanceproperty was declared inEnvironmentPropsand set in thepropsobject, but it was not being passed to theMainStackconstructor.Solution
Added
useNatInstance: props.useNatInstanceto theMainStackconstructor call.Changes
cdk/bin/cdk.tsto pass theuseNatInstanceprop toMainStackThis ensures that the
useNatInstanceconfiguration is properly propagated to the main stack, allowing users to control whether to use NAT instances or NAT gateways.