Skip to content

Commit aaed990

Browse files
authored
Merge pull request #2921 from kakakakakku/lambda-durable-human-approval-sam
lambda-durable-human-approval-sam: Fix hardcoded API Gateway URL by using environment variable
2 parents 91afcef + 1d069b0 commit aaed990

2 files changed

Lines changed: 8 additions & 6 deletions

File tree

lambda-durable-human-approval-sam/README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ This pattern demonstrates a human-in-the-loop approval workflow using AWS Lambda
44

55
**Important:** Please check the [AWS documentation](https://docs.aws.amazon.com/lambda/latest/dg/durable-functions.html) for regions currently supported by AWS Lambda durable functions.
66

7-
Learn more about this pattern at Serverless Land Patterns: https://serverlessland.com/patterns/lambda-durable-hitl-approval-sam
7+
Learn more about this pattern at Serverless Land Patterns: https://serverlessland.com/patterns/lambda-durable-human-approval-sam
88

99
## Architecture
1010

@@ -44,7 +44,7 @@ The pattern uses Lambda durable functions to implement a cost-effective approval
4444

4545
1. Navigate to the pattern directory:
4646
```bash
47-
cd lambda-durable-hitl-approval-sam
47+
cd lambda-durable-human-approval-sam
4848
```
4949

5050
2. Build the SAM application:
@@ -197,14 +197,14 @@ sam deploy --parameter-overrides ApproverEmail=new-email@example.com
197197

198198
Monitor the durable function:
199199
```bash
200-
aws logs tail /aws/lambda/lambda-durable-hitl-approval-ApprovalFunction-XXXXX \
200+
aws logs tail /aws/lambda/lambda-durable-human-approval-ApprovalFunction \
201201
--region us-east-2 \
202202
--follow
203203
```
204204

205205
Monitor the callback handler:
206206
```bash
207-
aws logs tail /aws/lambda/lambda-durable-hitl-approv-CallbackHandlerFunction-XXXXX \
207+
aws logs tail /aws/lambda/lambda-durable-human-approval-CallbackHandlerFunction \
208208
--region us-east-2 \
209209
--follow
210210
```
@@ -214,7 +214,7 @@ aws logs tail /aws/lambda/lambda-durable-hitl-approv-CallbackHandlerFunction-XXX
214214
## Cleanup
215215

216216
```bash
217-
sam delete --stack-name lambda-durable-hitl-approval --region us-east-2
217+
sam delete --stack-name lambda-durable-human-approval --region us-east-2
218218
```
219219

220220

lambda-durable-human-approval-sam/template.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ Resources:
3636
CallbackHandlerFunction:
3737
Type: AWS::Serverless::Function
3838
Properties:
39+
FunctionName: !Sub '${AWS::StackName}-CallbackHandlerFunction'
3940
CodeUri: src/
4041
Handler: callback_handler.lambda_handler
4142
Runtime: python3.14
@@ -56,6 +57,7 @@ Resources:
5657
ApprovalFunction:
5758
Type: AWS::Serverless::Function
5859
Properties:
60+
FunctionName: !Sub '${AWS::StackName}-ApprovalFunction'
5961
CodeUri: src/
6062
Handler: lambda_function.lambda_handler
6163
Runtime: python3.14
@@ -139,7 +141,7 @@ Resources:
139141
x-amazon-apigateway-integration:
140142
type: aws
141143
httpMethod: POST
142-
uri: !Sub 'arn:aws:apigateway:${AWS::Region}:lambda:path/2015-03-31/functions/${ApprovalFunction.Arn}:live/invocations'
144+
uri: !Sub 'arn:aws:apigateway:${AWS::Region}:lambda:path/2015-03-31/functions/arn:aws:lambda:${AWS::Region}:${AWS::AccountId}:function:${AWS::StackName}-ApprovalFunction:live/invocations'
143145
requestParameters:
144146
integration.request.header.X-Amz-Invocation-Type: "'Event'"
145147
responses:

0 commit comments

Comments
 (0)