Skip to content

Commit 0ed1ac3

Browse files
committed
Merge branch 'fix/no-activate-bda-sync' into 'develop'
Sync to BDA no longer auto-activates the config version See merge request genaiic-reusable-assets/engagement-artifacts/genaiic-idp-accelerator!569
2 parents 6ee6d7f + 7c221b0 commit 0ed1ac3

3 files changed

Lines changed: 48 additions & 14 deletions

File tree

CHANGELOG.md

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ SPDX-License-Identifier: MIT-0
77

88
### Changed
99

10+
- **Sync to BDA no longer auto-activates the config version** — Previously, performing "Sync to BDA" would automatically set the current config version as active. Since each config version now has its own BDA project, auto-activation is unnecessary. Users can manually choose which version to activate via the Versions table.
11+
1012
- **Removed `Bedrock Data Automation (BDA) Project ARN` CloudFormation parameter** — The deploy-time `Pattern1BDAProjectArn` parameter has been removed as it was redundant with the per-config-version BDA project management already available in the Web UI, CLI, and GraphQL API. BDA projects are now managed entirely post-deployment: enable `use_bda: true` in your configuration, then use "Sync to BDA" to create or link a BDA project, or "Sync from BDA" to import from any existing BDA project. This simplifies the deployment experience (one fewer parameter) and better aligns the CloudFormation interface with the system's actual architecture. Existing deployed stacks are unaffected — runtime BDA project ARN resolution reads from DynamoDB per-version tracking, not from the CloudFormation parameter. Also removed the unused `nested/bda-lending-project/` directory (dead code not referenced by any template) and the legacy `BDA_PROJECT_ARN` environment variable fallback from the sync resolver.
1113

1214
### Fixed
@@ -44,6 +46,8 @@ SPDX-License-Identifier: MIT-0
4446

4547
### Changed
4648

49+
- **Sync to BDA no longer auto-activates the config version** — Previously, performing "Sync to BDA" would automatically set the current config version as active. Since each config version now has its own BDA project, auto-activation is unnecessary. Users can manually choose which version to activate via the Versions table. The "Sync to BDA" confirmation modal text has been updated accordingly.
50+
4751
- **OCR Benchmark Config Optimization** — Optimized `config_library/unified/ocr-benchmark` configuration with targeted field descriptions, explicit model/prompt/OCR settings, and corrected date format (YYYY-MM-DD to match ground truth). Improved overall extraction accuracy from 51.5% to 75.2% on the full 293-document benchmark at equivalent cost (~$2.62). Classification remains 100% across all 9 document classes. ([#220](https://github.com/aws-solutions-library-samples/accelerated-intelligent-document-processing-on-aws/pull/220))
4852

4953
- **GraphQL Type Generation & Unit Testing** — Replaced 60+ hand-written GraphQL query/mutation/subscription files with auto-generated types via `@graphql-codegen`, added typed AWSJSON parsers with unit tests (vitest + jsdom), and integrated a CI codegen-check to prevent type drift.
@@ -84,6 +88,8 @@ SPDX-License-Identifier: MIT-0
8488

8589
### Changed
8690

91+
- **Sync to BDA no longer auto-activates the config version** — Previously, performing "Sync to BDA" would automatically set the current config version as active. Since each config version now has its own BDA project, auto-activation is unnecessary. Users can manually choose which version to activate via the Versions table. The "Sync to BDA" confirmation modal text has been updated accordingly.
92+
8793
- **Switched `idp_sdk` pyproject.toml to auto-discovery** — Replaced explicit subpackage listing with `setuptools.packages.find` using `include = ["idp_sdk*"]` so new subpackages are automatically included without manual pyproject.toml updates.
8894

8995
- **Resilient Test Set Deployment — Graceful Degradation on Download Failures** — All test set deployer Lambdas (RealKIE-FCC, OmniAI-OCR-Benchmark, DocSplit-Poly-Seq) now handle download failures gracefully instead of causing CloudFormation stack rollbacks. When a dataset source (HuggingFace) is unreachable or a download fails, the deployer creates a FAILED test set record in DynamoDB with a descriptive error message visible in the Test Studio UI, and sends `cfnresponse.SUCCESS` to CloudFormation so the stack deployment continues. Previously failed deployments are automatically retried on the next stack update. This ensures transient third-party service outages never block IDP infrastructure deployment.
@@ -220,6 +226,8 @@ SPDX-License-Identifier: MIT-0
220226

221227
### Changed
222228

229+
- **Sync to BDA no longer auto-activates the config version** — Previously, performing "Sync to BDA" would automatically set the current config version as active. Since each config version now has its own BDA project, auto-activation is unnecessary. Users can manually choose which version to activate via the Versions table. The "Sync to BDA" confirmation modal text has been updated accordingly.
230+
223231
- **HITL Decoupled from Step Functions**: HITL review operations now update document status directly in DynamoDB without triggering workflow reprocessing, improving reliability and reducing unintended side effects
224232

225233
- **Renamed TestSet from RVL-CDIP-N-MP to DocSplit-Poly-Seq**
@@ -364,6 +372,8 @@ SPDX-License-Identifier: MIT-0
364372

365373
### Changed
366374

375+
- **Sync to BDA no longer auto-activates the config version** — Previously, performing "Sync to BDA" would automatically set the current config version as active. Since each config version now has its own BDA project, auto-activation is unnecessary. Users can manually choose which version to activate via the Versions table. The "Sync to BDA" confirmation modal text has been updated accordingly.
376+
367377
- **Scripts Directory Reorganization**
368378
- Consolidated development environment setup scripts into `scripts/setup/` subdirectory
369379
- Moved CI/CD scripts (`codebuild_deployment.py`, `integration_test_deployment.py`, `validate_buildspec.py`, `typecheck_pr_changes.py`, `validate_service_role_permissions.py`) into `scripts/sdlc/` subdirectory
@@ -461,6 +471,8 @@ SPDX-License-Identifier: MIT-0
461471

462472
### Changed
463473

474+
- **Sync to BDA no longer auto-activates the config version** — Previously, performing "Sync to BDA" would automatically set the current config version as active. Since each config version now has its own BDA project, auto-activation is unnecessary. Users can manually choose which version to activate via the Versions table. The "Sync to BDA" confirmation modal text has been updated accordingly.
475+
464476
- **HITL Configuration**
465477
- HITL is now disabled by default in the configuration
466478
- Users must explicitly enable HITL in the Configuration page (Assessment & HITL Configuration section) to trigger human review workflows
@@ -476,6 +488,8 @@ SPDX-License-Identifier: MIT-0
476488

477489
### Changed
478490

491+
- **Sync to BDA no longer auto-activates the config version** — Previously, performing "Sync to BDA" would automatically set the current config version as active. Since each config version now has its own BDA project, auto-activation is unnecessary. Users can manually choose which version to activate via the Versions table. The "Sync to BDA" confirmation modal text has been updated accordingly.
492+
479493
- **Lambda Layers Architecture for Improved Build Efficiency**
480494
- Replaced bundled `idp_common` package dependencies in individual Lambda functions with three shared Lambda Layers
481495
- **Three Specialized Layers**:
@@ -633,6 +647,8 @@ SPDX-License-Identifier: MIT-0
633647

634648
### Changed
635649

650+
- **Sync to BDA no longer auto-activates the config version** — Previously, performing "Sync to BDA" would automatically set the current config version as active. Since each config version now has its own BDA project, auto-activation is unnecessary. Users can manually choose which version to activate via the Versions table. The "Sync to BDA" confirmation modal text has been updated accordingly.
651+
636652
- **Test Studio UI Enhancements for Improved Table Layouts and User Experience**
637653
- Added resizable columns and CollectionPreferences with wrap lines for all tables in TestComparison and TestResults
638654
- Combined accuracy and split classification metrics into collapsible "Average Accuracy and Split Metrics" section with expandable "Additional Metrics" for comprehensive review
@@ -786,6 +802,8 @@ SPDX-License-Identifier: MIT-0
786802

787803
### Changed
788804

805+
- **Sync to BDA no longer auto-activates the config version** — Previously, performing "Sync to BDA" would automatically set the current config version as active. Since each config version now has its own BDA project, auto-activation is unnecessary. Users can manually choose which version to activate via the Versions table. The "Sync to BDA" confirmation modal text has been updated accordingly.
806+
789807
- **Improved Temperature and Top_P Parameter Logic for Deterministic Output**
790808
- Changed inference parameter selection logic to allow `temperature=0.0` for deterministic output (recommended by Anthropic and other model providers)
791809
- **New Logic**: Uses `top_p` only when it has a positive value (> 0); otherwise uses `temperature` including `temperature=0.0`
@@ -945,6 +963,8 @@ SPDX-License-Identifier: MIT-0
945963

946964
### Changed
947965

966+
- **Sync to BDA no longer auto-activates the config version** — Previously, performing "Sync to BDA" would automatically set the current config version as active. Since each config version now has its own BDA project, auto-activation is unnecessary. Users can manually choose which version to activate via the Versions table. The "Sync to BDA" confirmation modal text has been updated accordingly.
967+
948968
- **Containerized Pattern-1 and Pattern-3 Deployment Pipelines**
949969
- Migrated Pattern-1 and Pattern-3 Lambda functions to Docker image deployments (following Pattern-2 approach from v0.3.20)
950970
- Builds and pushes all Lambda images via CodeBuild with automated ECR cleanup
@@ -978,6 +998,8 @@ SPDX-License-Identifier: MIT-0
978998

979999
### Changed
9801000

1001+
- **Sync to BDA no longer auto-activates the config version** — Previously, performing "Sync to BDA" would automatically set the current config version as active. Since each config version now has its own BDA project, auto-activation is unnecessary. Users can manually choose which version to activate via the Versions table. The "Sync to BDA" confirmation modal text has been updated accordingly.
1002+
9811003
- **Configuration Library Updates with JSON Schema Support**
9821004
- Updated configuration library with JSON schema format for lending package, bank statement, and RVL-CDIP package samples
9831005
- Enhanced configuration files to align with JSON Schema Draft 2020-12 format introduced in v0.4.0
@@ -1110,6 +1132,8 @@ SPDX-License-Identifier: MIT-0
11101132

11111133
### Changed
11121134

1135+
- **Sync to BDA no longer auto-activates the config version** — Previously, performing "Sync to BDA" would automatically set the current config version as active. Since each config version now has its own BDA project, auto-activation is unnecessary. Users can manually choose which version to activate via the Versions table. The "Sync to BDA" confirmation modal text has been updated accordingly.
1136+
11131137
- **Migrated Evaluation from EventBridge Trigger to Step Functions Workflow**
11141138
- Moved evaluation processing from external EventBridge-triggered Lambda to integrated Step Functions workflow step
11151139
- **Race Condition Eliminated**: Evaluation now runs inside state machine before WorkflowTracker marks documents COMPLETE, preventing premature completion status when evaluation is still running
@@ -1165,6 +1189,8 @@ SPDX-License-Identifier: MIT-0
11651189

11661190
### Changed
11671191

1192+
- **Sync to BDA no longer auto-activates the config version** — Previously, performing "Sync to BDA" would automatically set the current config version as active. Since each config version now has its own BDA project, auto-activation is unnecessary. Users can manually choose which version to activate via the Versions table. The "Sync to BDA" confirmation modal text has been updated accordingly.
1193+
11681194
- **Containerized Pattern-2 deployment pipeline** that builds and pushes all Lambda images via CodeBuild using the new Dockerfile, plus automated ECR cleanup and tests.
11691195
- Lambda docker image deployments have a 10 GB image size limit compared to the 250 MB zip limit of regular deployment. This however doesn't allow for viewing the code in the AWS console.
11701196
The change was introduced to accommodate the increased package size of introducing Strands into the package dependencies.
@@ -1261,6 +1287,8 @@ SPDX-License-Identifier: MIT-0
12611287

12621288
### Changed
12631289

1290+
- **Sync to BDA no longer auto-activates the config version** — Previously, performing "Sync to BDA" would automatically set the current config version as active. Since each config version now has its own BDA project, auto-activation is unnecessary. Users can manually choose which version to activate via the Versions table. The "Sync to BDA" confirmation modal text has been updated accordingly.
1291+
12641292
- Add UI code lint/validation to publish.py script
12651293

12661294
### Fixed
@@ -1437,6 +1465,8 @@ SPDX-License-Identifier: MIT-0
14371465

14381466
### Changed
14391467

1468+
- **Sync to BDA no longer auto-activates the config version** — Previously, performing "Sync to BDA" would automatically set the current config version as active. Since each config version now has its own BDA project, auto-activation is unnecessary. Users can manually choose which version to activate via the Versions table. The "Sync to BDA" confirmation modal text has been updated accordingly.
1469+
14401470
- **Reverted to python3.12 runtime to resolve build package dependency problems**
14411471

14421472
### Fixed
@@ -1512,6 +1542,8 @@ SPDX-License-Identifier: MIT-0
15121542

15131543
### Changed
15141544

1545+
- **Sync to BDA no longer auto-activates the config version** — Previously, performing "Sync to BDA" would automatically set the current config version as active. Since each config version now has its own BDA project, auto-activation is unnecessary. Users can manually choose which version to activate via the Versions table. The "Sync to BDA" confirmation modal text has been updated accordingly.
1546+
15151547
- **Updated Python Lambda Runtime to 3.13**
15161548

15171549
### Fixed
@@ -1581,6 +1613,8 @@ SPDX-License-Identifier: MIT-0
15811613

15821614
### Changed
15831615

1616+
- **Sync to BDA no longer auto-activates the config version** — Previously, performing "Sync to BDA" would automatically set the current config version as active. Since each config version now has its own BDA project, auto-activation is unnecessary. Users can manually choose which version to activate via the Versions table. The "Sync to BDA" confirmation modal text has been updated accordingly.
1617+
15841618
- Updated lending_package.pdf sample with more realistic driver's license image
15851619

15861620
### Fixed
@@ -1610,6 +1644,8 @@ SPDX-License-Identifier: MIT-0
16101644

16111645
### Changed
16121646

1647+
- **Sync to BDA no longer auto-activates the config version** — Previously, performing "Sync to BDA" would automatically set the current config version as active. Since each config version now has its own BDA project, auto-activation is unnecessary. Users can manually choose which version to activate via the Versions table. The "Sync to BDA" confirmation modal text has been updated accordingly.
1648+
16131649
- **Converted text confidence data format from JSON to markdown table for improved readability and reduced token usage**
16141650
- Removed unnecessary "page_count" field
16151651
- Changed "text_blocks" array to "text" field containing a markdown table with Text and Confidence columns
@@ -1707,6 +1743,8 @@ SPDX-License-Identifier: MIT-0
17071743

17081744
### Changed
17091745

1746+
- **Sync to BDA no longer auto-activates the config version** — Previously, performing "Sync to BDA" would automatically set the current config version as active. Since each config version now has its own BDA project, auto-activation is unnecessary. Users can manually choose which version to activate via the Versions table. The "Sync to BDA" confirmation modal text has been updated accordingly.
1747+
17101748
- **Default behavior for image attachment in Pattern-2 and Pattern3**
17111749
- If the prompt contains a `{DOCUMENT_IMAGE}` placeholder, keep the current behavior (insert image at placeholder)
17121750
- If the prompt does NOT contain a `{DOCUMENT_IMAGE}` placeholder, do NOT attach the image at all
@@ -1875,6 +1913,8 @@ SPDX-License-Identifier: MIT-0
18751913

18761914
### Changed
18771915

1916+
- **Sync to BDA no longer auto-activates the config version** — Previously, performing "Sync to BDA" would automatically set the current config version as active. Since each config version now has its own BDA project, auto-activation is unnecessary. Users can manually choose which version to activate via the Versions table. The "Sync to BDA" confirmation modal text has been updated accordingly.
1917+
18781918
- Pin packages to tested versions to avoid vulnerability from incompatible new package versions.
18791919
- Updated reporting data to use document's queued_time for consistent timestamps
18801920
- Create new extensible SaveReportingData class in idp_common package for saving evaluation results to Parquet format
@@ -2037,6 +2077,8 @@ SPDX-License-Identifier: MIT-0
20372077

20382078
### Changed
20392079

2080+
- **Sync to BDA no longer auto-activates the config version** — Previously, performing "Sync to BDA" would automatically set the current config version as active. Since each config version now has its own BDA project, auto-activation is unnecessary. Users can manually choose which version to activate via the Versions table. The "Sync to BDA" confirmation modal text has been updated accordingly.
2081+
20402082
- **Simplified Model Configuration Architecture**
20412083
- Removed individual model parameters from main template: `Pattern1SummarizationModel`, `Pattern2ClassificationModel`, `Pattern2ExtractionModel`, `Pattern2SummarizationModel`, `Pattern3ExtractionModel`, `Pattern3SummarizationModel`, `EvaluationLLMModelId`
20422084
- Model selection now handled through enum constraints in UpdateSchemaConfig sections within each pattern template
@@ -2082,6 +2124,8 @@ SPDX-License-Identifier: MIT-0
20822124

20832125
### Changed
20842126

2127+
- **Sync to BDA no longer auto-activates the config version** — Previously, performing "Sync to BDA" would automatically set the current config version as active. Since each config version now has its own BDA project, auto-activation is unnecessary. Users can manually choose which version to activate via the Versions table. The "Sync to BDA" confirmation modal text has been updated accordingly.
2128+
20852129
- Refactored code for better maintainability
20862130
- Updated UI components to support markdown table viewing
20872131
- Set default evaluation model to Claude 3 Haiku

src/ui/src/components/configuration-layout/ConfigurationLayout.tsx

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1543,17 +1543,6 @@ const ConfigurationLayout = (): React.JSX.Element => {
15431543
}, 5000);
15441544
}
15451545
logger.debug('BDA/IDP sync completed successfully');
1546-
1547-
// If this was sync to BDA, activate the version (skip confirmation to prevent circular call)
1548-
if (direction === 'idp_to_bda') {
1549-
try {
1550-
await handleActivateVersion(currentVersionName, true); // Skip confirmation
1551-
logger.debug(`Activated version ${currentVersionName} after sync to BDA`);
1552-
} catch (activateErr) {
1553-
logger.error('Failed to activate version after sync:', activateErr);
1554-
// Don't fail the sync, just log the error
1555-
}
1556-
}
15571546
} else {
15581547
const errorMsg = String(response?.error?.message || response?.message || 'Sync operation failed');
15591548
setSyncError(errorMsg);
@@ -2619,9 +2608,8 @@ const ConfigurationLayout = (): React.JSX.Element => {
26192608
}
26202609
>
26212610
<SpaceBetween size="m">
2622-
<Alert type="warning">
2623-
This will sync your IDP document classes to BDA blueprints and set <strong>{currentVersionName}</strong> as the active
2624-
configuration version.
2611+
<Alert type="info">
2612+
This will sync your IDP document classes as BDA blueprints for version <strong>{currentVersionName}</strong>.
26252613
</Alert>
26262614
<FormField label="BDA Project" description="Choose how to sync your configuration to BDA.">
26272615
<RadioGroup

src/ui/src/hooks/use-graphql-api.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import { ConsoleLogger } from 'aws-amplify/utils';
77
import useAppContext from '../contexts/app';
88
import {
99
listDocuments,
10+
// eslint-disable-next-line @typescript-eslint/no-unused-vars
1011
getDocumentCount,
1112
getDocument,
1213
deleteDocument,
@@ -50,6 +51,7 @@ interface GraphQLSubscriptionRef {
5051
unsubscribe: () => void;
5152
}
5253

54+
// eslint-disable-next-line @typescript-eslint/no-unused-vars
5355
interface DocumentListItem {
5456
ObjectKey: string;
5557
PK?: string;

0 commit comments

Comments
 (0)