Conversation
kazmer97
force-pushed
the
feat/better-retry
branch
4 times, most recently
from
0cd1cfb to
23f170b
Compare
rstrahan
requested changes
Nov 21, 2025
Contributor
There was a problem hiding this comment.
Please include pattern-3 as well.. these fixes apply to both patterns.
kazmer97
force-pushed
the
feat/better-retry
branch
from
b71ff15 to
b7dc88d
Compare
rstrahan
requested changes
Nov 25, 2025
Contributor
rstrahan
left a comment
rstrahan
left a comment
There was a problem hiding this comment.
Three main comments
-
There's a new conflict with the develop branch after latest merge of fix for #136
-
When I deploy this branch and process a document in the stack, using agentic extraction, I get error below.. Can you do a clean publish and deploy, and see if you also get this error after enabling agentic extraction in the config.
Error: ImportError: Agentic extraction requires Python 3.10+ and strands-agents dependencies. Install with: pip install 'idp_common[agents]' or use agentic=False
- I'm overwhelmed by the volume of changes in this PR - many of which seem formatter related and unrelated to the 'better retry' focus of the PR, but the effect is to hinder my ability to review the changes.
Can you clean up the changes to include only the changes related to the retry improvements, tx.
Contributor
There was a problem hiding this comment.
Getting merge conflicts in this file
Contributor
There was a problem hiding this comment.
Also huge volume of changes that seem unrelated to 'better retries' - I can't review them..
kazmer97
force-pushed
the
feat/better-retry
branch
from
8ba8653 to
9ae0feb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.