Skip to content
This repository was archived by the owner on Apr 8, 2026. It is now read-only.

Commit 448bdc5

Browse files
authored
added rel="noopener noreferrer" (#52)
Added rel="noopener noreferrer" on <a> HTML tag.
1 parent ff1963c commit 448bdc5

5 files changed

Lines changed: 9 additions & 10 deletions

File tree

source/console/app/admin/settings/settings.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ <h1>Settings</h1>
1818
<section>
1919
<form ng-show="appconfig.setting" name="settingsForm" novalidate ng-submit="updateAppSettings(appconfig, settingsForm.$valid)">
2020
<awsui-control-group class="full-width" validation-message="" label="Application Url">
21-
<a target="_blank" href='{{appconfig.setting.appUrl}}'>{{appconfig.setting.appUrl}}</a>
21+
<a target="_blank" href='{{appconfig.setting.appUrl}}' rel="noopener noreferrer">{{appconfig.setting.appUrl}}</a>
2222
</awsui-control-group>
2323
<awsui-control-group class="full-width" validation-message="" label="Default Amazon S3 Bucket">
2424
{{appconfig.setting.defaultS3Bucket}}
@@ -27,10 +27,10 @@ <h1>Settings</h1>
2727
{{appconfig.setting.esindex}}
2828
</awsui-control-group>
2929
<awsui-control-group class="full-width" validation-message="" label="Amazon Elasticsearch Url">
30-
<a target="_blank" href='{{appconfig.setting.esurl}}'>{{appconfig.setting.esurl}}</a>
30+
<a href='{{appconfig.setting.esurl}}' target="_blank" rel="noopener noreferrer">{{appconfig.setting.esurl}}</a>
3131
</awsui-control-group>
3232
<awsui-control-group class="full-width" validation-message="" label="Amazon Elasticsearch Kibana Url">
33-
<a target="_blank" href='{{appconfig.setting.esurl}}/_plugin/kibana/'>{{appconfig.setting.esurl}}/_plugin/kibana/</a>
33+
<a href='{{appconfig.setting.esurl}}/_plugin/kibana/' target="_blank" rel="noopener noreferrer">{{appconfig.setting.esurl}}/_plugin/kibana/</a>
3434
</awsui-control-group>
3535
<awsui-control-group class="full-width" validation-message="" label="Cognito User Pool Id">
3636
{{appconfig.setting.idp}}

source/console/app/cart/cart.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ <h1>My Cart</h1>
6464
<td style="padding-bottom:20px; padding-top:20px;">
6565
<div><b>{{item.name}}</b><a class='awsui-util-ml-s' href='#package/{{item.package_id}}'><i class="fa fa-external-link"></i></a></div>
6666
<div class="awsui-text-small"><i>{{item.description}}</i></div>
67-
<div class="pull-left awsui-util-mr-s">[ <a target="_blank" href="{{item.url}}">download link</a> ]</div>
67+
<div class="pull-left awsui-util-mr-s">[ <a href="{{item.url}}" target="_blank" rel="noopener noreferrer">download link</a> ]</div>
6868
<div class="pull-left">[ {{item.format === 'bucket-key' ? 'Amazon S3 Bucket/Key' : 'Signed URLs'}} ]</div>
6969
</td>
7070
<td>{{item.expires | date: 'medium'}}</td>

source/console/app/dashboard/dashboard.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@ <h1>Dashboard</h1>
1010
<hr />
1111
<div class="title">Getting Started</div>
1212
<div class="detail">
13-
Read our <a target="_blank" href="http://docs.awssolutionsbuilder.com/data-lake/index.html">documentation</a> to learn more about AWS Data Lake.
13+
Read our <a href="http://docs.awssolutionsbuilder.com/data-lake/index.html" target="_blank" rel="noopener noreferrer">documentation</a> to learn more about AWS Data Lake.
1414
</div>
1515
<hr />
1616
<div class="title">Feedback</div>
1717
<div class="detail">
18-
<a target="_blank" href="https://docs.aws.amazon.com/forms/aws-doc-feedback?hidden_service_name=AWS%20Solutions&hidden_guide_name=Data%20Lake%20Solution&hidden_api_version=&hidden_file_name=data%20lake%20console">Tell us what you think</a> about the AWS Data Lake.
18+
<a href="https://docs.aws.amazon.com/forms/aws-doc-feedback?hidden_service_name=AWS%20Solutions&hidden_guide_name=Data%20Lake%20Solution&hidden_api_version=&hidden_file_name=data%20lake%20console" target="_blank" rel="noopener noreferrer">Tell us what you think</a> about the AWS Data Lake.
1919
</div>
2020
</div>
2121
<div class="c-m-8 c-m-pull-4" style="padding-left:0px;">

source/console/app/main/main.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<ul class="navigation">
44
<li class="awsui-util-f-l"><a href="/" class="home-link">Data Lake</a></li>
55
<li class="awsui-util-f-r"><a href="" ng-click="signout()">Sign Out</a></li>
6-
<li class="awsui-util-f-r"><a target="_blank" href="http://docs.awssolutionsbuilder.com/data-lake/index.html">Support</a></li>
6+
<li class="awsui-util-f-r"><a href="http://docs.awssolutionsbuilder.com/data-lake/index.html" target="_blank" rel="noopener noreferrer">Support</a></li>
77
<li class="awsui-util-f-r">
88
<a href="#cart" style="text-decoration:none;">
99
<i style="color:#fff" class="fa fa-shopping-basket fa-lg"></i>

source/console/app/package/package.html

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ <h2>Manifest</h2>
237237
<th>
238238
Manifest File
239239
<div>
240-
<small style="font-weight:normal;">Upload a manifest file with the location of existing datasets in Amazon S3 to link to the package. <a href="http://docs.awssolutionsbuilder.com/data-lake/user-guide/working-with-packages/" target="_blank">Learn more.</a></small>
240+
<small style="font-weight:normal;">Upload a manifest file with the location of existing datasets in Amazon S3 to link to the package. <a href="http://docs.awssolutionsbuilder.com/data-lake/user-guide/working-with-packages/" target="_blank" rel="noopener noreferrer">Learn more.</a></small>
241241
</div>
242242
</th>
243243
<th></th>
@@ -286,8 +286,7 @@ <h2>History</h2>
286286
<h2>Crawler</h2>
287287
<awsui-alert ng-if="pckgManifest.length != 0 && pckgContent.length > 0" dismissible="false" header="Important">
288288
<b>data-lake-packages-role</b> and <b>data-lake-package-crawler-role</b> must provide access to your Amazon S3 imported datasets.
289-
<a href="http://docs.awssolutionsbuilder.com/data-lake/user-guide/working-with-packages/" target="_blank">Learn more.</a>
290-
</awsui-alert>
289+
<a href="http://docs.awssolutionsbuilder.com/data-lake/user-guide/working-with-packages/" target="_blank" rel="noopener noreferrer">Learn more.</a> </awsui-alert>
291290
<div class="center-text" ng-show="pckgContent.length == 0">
292291
<label>No content available to be crawled.</label>
293292
</div>

0 commit comments

Comments
 (0)