feat: support exif autoOrient from base64encoded payloads#633
Open
eortiz-tracktik wants to merge 1 commit into
Open
feat: support exif autoOrient from base64encoded payloads#633eortiz-tracktik wants to merge 1 commit into
eortiz-tracktik wants to merge 1 commit into
Conversation
Service code that makes autoOrient() unreachable via a JSON payload.
Here is the breakdown of the issue:
The JSON Limitation: The JSON.parse() method (and the JSON standard) cannot produce a value of undefined.
If you send {"rotate": null}, then edits.rotate is null.
If you send {"rotate": 0}, then edits.rotate is 0.
The Condition (edits.rotate === undefined):
Since you must provide the key for the loop to enter the case, edits.rotate will always have a value (like null).
null === undefined is false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#606
#623
Description of changes:
Code makes autoOrient() unreachable via a base64encoded/JSON payload.
Here is the breakdown of the issue:
The JSON Limitation: The JSON.parse() method (and the JSON standard) cannot produce a value of undefined.
The Condition (edits.rotate === undefined):
null === undefined is false.
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.