Dit v3 enhancements Final PR#648
Open
vishalsaxena-devops wants to merge 2 commits into
Open
Conversation
…formats - Added support for ICO and BMP formats in the image processing service, allowing them to pass through unchanged. - Implemented detection for animated PNGs (APNG) to ensure they are preserved during processing. - Updated transformation logic to skip format optimizations for ICO, BMP, SVG, and APNG sources. - Enhanced unit tests to cover new functionality, including handling of ICO, BMP, and APNG formats. - Adjusted format priority to prefer WebP over AVIF and added specific tests for format selection based on client acceptance headers. - Improved handling of animated WebP to prevent conversion to formats that cannot support animation.
Member
|
thanks Vishal for the PR, we will review these changes and evaluate if they can be applied to generic customer use-case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
This PR includes all the following issues as discussed with aws folks and this is currently been deployed in shared prod and non-prod that has these fixes included
BMP image format returns 500 error
Fix broken ICO + restore animation for WebP and APNG sources
Prefer AVIF over WebP in format auto-selection
Also cross-region aws bucket mapping support
Description of changes:
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.