Skip to content

Commit 07b7430

Browse files
committed
fix: use dnsSuffix() for multi-partition endpoint support
Replace hardcoded .amazonaws.com in api-client.ts with dnsSuffix() to support GovCloud and other partitions. Suppress lint for example placeholder text in AddHarnessScreen.
1 parent 502e089 commit 07b7430

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

src/cli/aws/api-client.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
* When the SDK adds native commands for new APIs, we will migrate callers to the SDK client.
44
*/
55
import { getCredentialProvider } from './account';
6+
import { dnsSuffix } from './partition';
67
import { Sha256 } from '@aws-crypto/sha256-js';
78
import { defaultProvider } from '@aws-sdk/credential-provider-node';
89
import { HttpRequest } from '@smithy/protocol-http';
@@ -118,10 +119,10 @@ export function resolveEndpoint(region: string, plane: ApiPlane): string {
118119
if (plane === 'control') {
119120
if (stage === 'beta') return `https://beta.${region}.elcapcp.genesis-primitives.aws.dev`;
120121
if (stage === 'gamma') return `https://gamma.${region}.elcapcp.genesis-primitives.aws.dev`;
121-
return `https://bedrock-agentcore-control.${region}.amazonaws.com`;
122+
return `https://bedrock-agentcore-control.${region}.${dnsSuffix(region)}`;
122123
}
123124

124125
if (stage === 'beta') return `https://beta.${region}.elcapdp.genesis-primitives.aws.dev`;
125126
if (stage === 'gamma') return `https://gamma.${region}.elcapdp.genesis-primitives.aws.dev`;
126-
return `https://bedrock-agentcore.${region}.amazonaws.com`;
127+
return `https://bedrock-agentcore.${region}.${dnsSuffix(region)}`;
127128
}

src/cli/tui/screens/harness/AddHarnessScreen.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -362,6 +362,7 @@ export function AddHarnessScreen({ existingHarnessNames, onComplete, onExit }: A
362362
{isContainerUriStep && (
363363
<TextInput
364364
key="container-uri"
365+
// eslint-disable-next-line partition/no-hardcoded-endpoint-tld -- example placeholder, not a real endpoint
365366
prompt="Container image URI (e.g., 123456789012.dkr.ecr.us-east-1.amazonaws.com/my-harness:latest)"
366367
initialValue=""
367368
onSubmit={wizard.setContainerUri}

0 commit comments

Comments
 (0)