fix(payments): TUI credential propagation, dead type exports, schema alignment

- Fix TUI deploy bug: runPaymentPreDeploy now calls setAllCredentials so
  useDeployFlow.persistDeployedState has correct connector ARNs
- Remove export from 9 dead type interfaces in agentcore-payments.ts
- Rename PaymentCredentialProviderResult → PaymentCredentialProviderApiResult
  to resolve name collision with payment-types.ts
- Fix defaultSpendLimit schema mismatch: CDK now uses z.string().optional()
  matching CLI (was z.object({amount,currency}) — incompatible)
- Remove dead PaymentCredentialProviderResult re-export from barrel

Author: aidandaly24

src/cli/aws/agentcore-payments.ts

@@ -17,7 +17,7 @@ import { SignatureV4 } from '@smithy/signature-v4';
 
 // ── Create Payment Credential Provider ─────────────────────────────────────
 
-export interface CreateCoinbaseCdpCredentialProviderOptions {
+interface CreateCoinbaseCdpCredentialProviderOptions {
   region: string;
   name: string;
   vendor: 'CoinbaseCDP';
@@ -26,7 +26,7 @@ export interface CreateCoinbaseCdpCredentialProviderOptions {
   walletSecret: string;
 }
 
-export interface CreateStripePrivyCredentialProviderOptions {
+interface CreateStripePrivyCredentialProviderOptions {
   region: string;
   name: string;
   vendor: 'StripePrivy';
@@ -36,40 +36,40 @@ export interface CreateStripePrivyCredentialProviderOptions {
   authorizationId: string;
 }
 
-export type CreatePaymentCredentialProviderOptions =
+type CreatePaymentCredentialProviderOptions =
   | CreateCoinbaseCdpCredentialProviderOptions
   | CreateStripePrivyCredentialProviderOptions;
 
-export interface PaymentCredentialProviderResult {
+interface PaymentCredentialProviderApiResult {
   credentialProviderArn: string;
   status: string;
 }
 
 // ── Update Payment Credential Provider ─────────────────────────────────────
 
-export type UpdatePaymentCredentialProviderOptions = CreatePaymentCredentialProviderOptions;
+type UpdatePaymentCredentialProviderOptions = CreatePaymentCredentialProviderOptions;
 
 // ── Get Payment Credential Provider ────────────────────────────────────────
 
-export interface GetPaymentCredentialProviderOptions {
+interface GetPaymentCredentialProviderOptions {
   region: string;
   name: string;
 }
 
-export interface PaymentCredentialProviderDetail {
+interface PaymentCredentialProviderDetail {
   credentialProviderArn: string;
   name: string;
   status: string;
 }
 
 // ── Get Payment Manager ───────────────────────────────────────────────────
 
-export interface GetPaymentManagerOptions {
+interface GetPaymentManagerOptions {
   region: string;
   paymentManagerId: string;
 }
 
-export interface PaymentManagerDetail {
+interface PaymentManagerDetail {
   paymentManagerId: string;
   paymentManagerArn: string;
   name: string;
@@ -205,7 +205,7 @@ function buildProviderConfigPayload(options: CreatePaymentCredentialProviderOpti
 
 export async function createPaymentCredentialProvider(
   options: CreatePaymentCredentialProviderOptions
-): Promise<PaymentCredentialProviderResult> {
+): Promise<PaymentCredentialProviderApiResult> {
   const { credentialProviderVendor, providerConfigurationInput } = buildProviderConfigPayload(options);
   const body = JSON.stringify({
     name: options.name,
@@ -219,7 +219,7 @@ export async function createPaymentCredentialProvider(
       method: 'POST',
       path: '/identities/CreatePaymentCredentialProvider',
       body,
-    })) as PaymentCredentialProviderResult;
+    })) as PaymentCredentialProviderApiResult;
 
     return {
       credentialProviderArn: data.credentialProviderArn,
@@ -234,7 +234,7 @@ export async function createPaymentCredentialProvider(
 
 export async function updatePaymentCredentialProvider(
   options: UpdatePaymentCredentialProviderOptions
-): Promise<PaymentCredentialProviderResult> {
+): Promise<PaymentCredentialProviderApiResult> {
   const { credentialProviderVendor, providerConfigurationInput } = buildProviderConfigPayload(options);
   const body = JSON.stringify({
     name: options.name,
@@ -248,7 +248,7 @@ export async function updatePaymentCredentialProvider(
       method: 'POST',
       path: '/identities/UpdatePaymentCredentialProvider',
       body,
-    })) as PaymentCredentialProviderResult;
+    })) as PaymentCredentialProviderApiResult;
 
     return {
       credentialProviderArn: data.credentialProviderArn,
@@ -409,7 +409,7 @@ async function signedDataPlaneRequest(options: {
 
 // ── Payment Session Types ─────────────────────────────────────────────────
 
-export interface GetOrCreatePaymentSessionOptions {
+interface GetOrCreatePaymentSessionOptions {
   region: string;
   managerArn: string;
   userId: string;

src/cli/aws/index.ts

@@ -33,7 +33,6 @@ export {
   deletePaymentCredentialProvider,
   getPaymentManager,
   getOrCreatePaymentSession,
-  type PaymentCredentialProviderResult,
 } from './agentcore-payments';
 export {
   DEFAULT_RUNTIME_USER_ID,

src/cli/tui/hooks/useCdkPreflight.ts

@@ -38,11 +38,25 @@ interface RunPaymentSetupOptions {
   updateStepByLabel: (label: string, update: Partial<Step>) => void;
   setPhase: (phase: PreflightPhase) => void;
   isRunningRef: React.MutableRefObject<boolean>;
+  setAllCredentials: React.Dispatch<
+    React.SetStateAction<
+      Record<string, { credentialProviderArn: string; clientSecretArn?: string; callbackUrl?: string }>
+    >
+  >;
 }
 
 async function runPaymentPreDeploy(opts: RunPaymentSetupOptions): Promise<boolean> {
-  const { projectSpec, awsTargets, runtimeCredentials, logger, setSteps, updateStepByLabel, setPhase, isRunningRef } =
-    opts;
+  const {
+    projectSpec,
+    awsTargets,
+    runtimeCredentials,
+    logger,
+    setSteps,
+    updateStepByLabel,
+    setPhase,
+    isRunningRef,
+    setAllCredentials,
+  } = opts;
 
   if (!hasPaymentManagers(projectSpec)) return true;
 
@@ -85,6 +99,15 @@ async function runPaymentPreDeploy(opts: RunPaymentSetupOptions): Promise<boolea
     targets: { ...existingState.targets, [target.name]: targetState },
   });
 
+  // Update in-memory credentials so useDeployFlow.persistDeployedState has correct ARNs
+  setAllCredentials(prev => {
+    const updated = { ...prev };
+    for (const [name, result] of Object.entries(paymentResult.credentialProviders)) {
+      updated[name] = { credentialProviderArn: result.credentialProviderArn };
+    }
+    return updated;
+  });
+
   logger.endStep('success');
   updateStepByLabel(LABEL_PAYMENTS, { status: 'success' });
   return true;
@@ -496,6 +519,7 @@ export function useCdkPreflight(options: PreflightOptions): PreflightResult {
           updateStepByLabel,
           setPhase,
           isRunningRef,
+          setAllCredentials,
         });
         if (!paymentOk) return;
 
@@ -629,6 +653,7 @@ export function useCdkPreflight(options: PreflightOptions): PreflightResult {
           updateStepByLabel,
           setPhase,
           isRunningRef,
+          setAllCredentials,
         });
         if (!paymentOkSkip) return;
 
@@ -880,6 +905,7 @@ export function useCdkPreflight(options: PreflightOptions): PreflightResult {
           updateStepByLabel,
           setPhase,
           isRunningRef,
+          setAllCredentials,
         });
         if (!paymentOkIdentity) return;