refactor(payments): merge credential setup into pre-deploy-identity

Payment credential providers use the same /identities/ endpoint as API key
and OAuth providers. Move setupPaymentCredentialProviders, hasPaymentCredentialProviders,
and cleanupPaymentCredentialProviders into pre-deploy-identity.ts alongside
the other credential provider operations.

- Delete pre-deploy-payments.ts (merged into pre-deploy-identity.ts)
- Delete payment-types.ts (types inlined in pre-deploy-identity.ts)
- Rename: setupPaymentResources → setupPaymentCredentialProviders
- Rename: hasPaymentManagers → hasPaymentCredentialProviders
- Update all import paths and barrel exports
- Update test imports

Author: aidandaly24

src/cli/commands/deploy/actions.ts

@@ -44,9 +44,9 @@ import { setupHttpGateways } from '../../operations/deploy/post-deploy-http-gate
 import { enableOnlineEvalConfigs } from '../../operations/deploy/post-deploy-online-evals';
 import {
   cleanupPaymentCredentialProviders,
-  hasPaymentManagers,
-  setupPaymentResources,
-} from '../../operations/deploy/pre-deploy-payments';
+  hasPaymentCredentialProviders,
+  setupPaymentCredentialProviders,
+} from '../../operations/deploy/pre-deploy-identity';
 import { toStackName } from '../import/import-utils';
 import type { DeployResult } from './types';
 import { StackSelectionStrategy } from '@aws-cdk/toolkit-lib';
@@ -261,10 +261,10 @@ export async function handleDeploy(options: ValidatedDeployOptions): Promise<Dep
 
     // Set up payment credential providers before CDK synth (secrets stay imperative)
     // PaymentManager, PaymentConnector, and IAM roles are created by CDK constructs
-    if (hasPaymentManagers(context.projectSpec)) {
+    if (hasPaymentCredentialProviders(context.projectSpec)) {
       startStep('Setting up payment credentials...');
 
-      const paymentPreDeployResult = await setupPaymentResources({
+      const paymentPreDeployResult = await setupPaymentCredentialProviders({
         projectSpec: context.projectSpec,
         configBaseDir: configIO.getConfigRoot(),
         region: target.region,

src/cli/operations/deploy/__tests__/pre-deploy-payments.test.ts

@@ -1,4 +1,4 @@
-import { cleanupPaymentCredentialProviders, setupPaymentResources } from '../pre-deploy-payments.js';
+import { cleanupPaymentCredentialProviders, setupPaymentCredentialProviders } from '../pre-deploy-identity.js';
 import { afterEach, describe, expect, it, vi } from 'vitest';
 
 // ============================================================================
@@ -115,10 +115,10 @@ function makeStripePrivySpec(credentialName = 'my-stripe-cred') {
 }
 
 // ============================================================================
-// setupPaymentResources
+// setupPaymentCredentialProviders
 // ============================================================================
 
-describe('setupPaymentResources', () => {
+describe('setupPaymentCredentialProviders', () => {
   afterEach(() => vi.clearAllMocks());
 
   it('returns empty credentialProviders when payments array is empty', async () => {
@@ -129,7 +129,7 @@ describe('setupPaymentResources', () => {
       runtimes: [],
     };
 
-    const result = await setupPaymentResources({
+    const result = await setupPaymentCredentialProviders({
       projectSpec: projectSpec as any,
       configBaseDir: BASE_DIR,
       region: REGION,
@@ -145,7 +145,7 @@ describe('setupPaymentResources', () => {
   it('returns error when .env.local does not exist', async () => {
     mockExistsSync.mockReturnValue(false);
 
-    const result = await setupPaymentResources({
+    const result = await setupPaymentCredentialProviders({
       projectSpec: makeCoinbaseSpec() as any,
       configBaseDir: BASE_DIR,
       region: REGION,
@@ -164,7 +164,7 @@ describe('setupPaymentResources', () => {
   it('lists all required StripePrivy vars in the missing .env.local error', async () => {
     mockExistsSync.mockReturnValue(false);
 
-    const result = await setupPaymentResources({
+    const result = await setupPaymentCredentialProviders({
       projectSpec: makeStripePrivySpec() as any,
       configBaseDir: BASE_DIR,
       region: REGION,
@@ -190,7 +190,7 @@ describe('setupPaymentResources', () => {
       status: 'ACTIVE',
     });
 
-    const result = await setupPaymentResources({
+    const result = await setupPaymentCredentialProviders({
       projectSpec: makeCoinbaseSpec() as any,
       configBaseDir: BASE_DIR,
       region: REGION,
@@ -223,7 +223,7 @@ describe('setupPaymentResources', () => {
       status: 'ACTIVE',
     });
 
-    const result = await setupPaymentResources({
+    const result = await setupPaymentCredentialProviders({
       projectSpec: makeCoinbaseSpec() as any,
       configBaseDir: BASE_DIR,
       region: REGION,
@@ -245,7 +245,7 @@ describe('setupPaymentResources', () => {
     });
     mockGetPaymentCredentialProvider.mockResolvedValue(null);
 
-    const result = await setupPaymentResources({
+    const result = await setupPaymentCredentialProviders({
       projectSpec: makeCoinbaseSpec() as any,
       configBaseDir: BASE_DIR,
       region: REGION,
@@ -267,7 +267,7 @@ describe('setupPaymentResources', () => {
     });
     mockGetPaymentCredentialProvider.mockResolvedValue(null);
 
-    const result = await setupPaymentResources({
+    const result = await setupPaymentCredentialProviders({
       projectSpec: makeStripePrivySpec() as any,
       configBaseDir: BASE_DIR,
       region: REGION,
@@ -295,7 +295,7 @@ describe('setupPaymentResources', () => {
       status: 'ACTIVE',
     });
 
-    await setupPaymentResources({
+    await setupPaymentCredentialProviders({
       projectSpec: makeCoinbaseSpec() as any,
       configBaseDir: BASE_DIR,
       region: REGION,
@@ -327,7 +327,7 @@ describe('setupPaymentResources', () => {
       status: 'ACTIVE',
     });
 
-    await setupPaymentResources({
+    await setupPaymentCredentialProviders({
       projectSpec: makeStripePrivySpec() as any,
       configBaseDir: BASE_DIR,
       region: REGION,

src/cli/operations/deploy/index.ts

@@ -41,15 +41,15 @@ export {
   type DestroyTargetOptions,
 } from './teardown';
 
-// Pre-deploy payment setup
+// Pre-deploy payment credential setup
 export {
-  setupPaymentResources,
-  hasPaymentManagers,
+  setupPaymentCredentialProviders,
+  hasPaymentCredentialProviders,
   cleanupPaymentCredentialProviders,
-  type SetupPaymentResourcesOptions,
-} from './pre-deploy-payments';
-
-export type { PaymentPreDeployResult, PaymentCredentialProviderResult } from './payment-types';
+  type SetupPaymentCredentialProvidersOptions,
+  type PaymentCredentialProvidersResult,
+  type PaymentCredentialProviderResult,
+} from './pre-deploy-identity';
 
 // Post-deploy observability setup
 export { setupTransactionSearch } from './post-deploy-observability';