test: add validation and routing tests for scaffold flow

Test source/host defaults, Lambda-only enforcement, --host rejection
for existing-endpoint, and handleAddGatewayTarget routing based on
source type.

Author: aidandaly24

src/cli/commands/add/__tests__/actions.test.ts

@@ -1,6 +1,15 @@
 import { buildGatewayTargetConfig } from '../actions.js';
 import type { ValidatedAddGatewayTargetOptions } from '../actions.js';
-import { describe, expect, it } from 'vitest';
+import { afterEach, describe, expect, it, vi } from 'vitest';
+
+const mockCreateToolFromWizard = vi.fn().mockResolvedValue({ toolName: 'test', projectPath: '/tmp' });
+const mockCreateExternalGatewayTarget = vi.fn().mockResolvedValue({ toolName: 'test', projectPath: '' });
+
+vi.mock('../../../operations/mcp/create-mcp', () => ({
+  createToolFromWizard: (...args: unknown[]) => mockCreateToolFromWizard(...args),
+  createExternalGatewayTarget: (...args: unknown[]) => mockCreateExternalGatewayTarget(...args),
+  createGatewayFromWizard: vi.fn(),
+}));
 
 describe('buildGatewayTargetConfig', () => {
   it('maps name, gateway, language correctly', () => {
@@ -66,3 +75,55 @@ describe('buildGatewayTargetConfig', () => {
     expect(config.outboundAuth).toBeUndefined();
   });
 });
+
+// Dynamic import to pick up mocks
+const { handleAddGatewayTarget } = await import('../actions.js');
+
+describe('handleAddGatewayTarget', () => {
+  afterEach(() => vi.clearAllMocks());
+
+  it('routes existing-endpoint to createExternalGatewayTarget', async () => {
+    const options: ValidatedAddGatewayTargetOptions = {
+      name: 'test-tool',
+      language: 'Other',
+      host: 'Lambda',
+      source: 'existing-endpoint',
+      endpoint: 'https://example.com/mcp',
+      gateway: 'my-gw',
+    };
+
+    await handleAddGatewayTarget(options);
+
+    expect(mockCreateExternalGatewayTarget).toHaveBeenCalledOnce();
+    expect(mockCreateToolFromWizard).not.toHaveBeenCalled();
+  });
+
+  it('routes create-new to createToolFromWizard', async () => {
+    const options: ValidatedAddGatewayTargetOptions = {
+      name: 'test-tool',
+      language: 'Python',
+      host: 'Lambda',
+      source: 'create-new',
+      gateway: 'my-gw',
+    };
+
+    await handleAddGatewayTarget(options);
+
+    expect(mockCreateToolFromWizard).toHaveBeenCalledOnce();
+    expect(mockCreateExternalGatewayTarget).not.toHaveBeenCalled();
+  });
+
+  it('routes to createToolFromWizard when source not specified', async () => {
+    const options: ValidatedAddGatewayTargetOptions = {
+      name: 'test-tool',
+      language: 'Python',
+      host: 'Lambda',
+      gateway: 'my-gw',
+    };
+
+    await handleAddGatewayTarget(options);
+
+    expect(mockCreateToolFromWizard).toHaveBeenCalledOnce();
+    expect(mockCreateExternalGatewayTarget).not.toHaveBeenCalled();
+  });
+});

src/cli/commands/add/__tests__/validate.test.ts

@@ -369,6 +369,47 @@ describe('validate', () => {
       const result = await validateAddGatewayTargetOptions(options);
       expect(result.valid).toBe(true);
     });
+
+    // Source and host defaults
+    it('defaults source to create-new when not specified', async () => {
+      const options: AddGatewayTargetOptions = { name: 'test-tool', language: 'Python' };
+      const result = await validateAddGatewayTargetOptions(options);
+      expect(result.valid).toBe(true);
+      expect(options.source).toBe('create-new');
+    });
+
+    it('defaults host to Lambda when not specified', async () => {
+      const options: AddGatewayTargetOptions = { name: 'test-tool', language: 'Python' };
+      const result = await validateAddGatewayTargetOptions(options);
+      expect(result.valid).toBe(true);
+      expect(options.host).toBe('Lambda');
+    });
+
+    // Lambda-only enforcement
+    it('rejects AgentCoreRuntime host for create-new', async () => {
+      const options: AddGatewayTargetOptions = {
+        name: 'test-tool',
+        language: 'Python',
+        source: 'create-new',
+        host: 'AgentCoreRuntime',
+      };
+      const result = await validateAddGatewayTargetOptions(options);
+      expect(result.valid).toBe(false);
+      expect(result.error).toBe('Only Lambda is supported as compute host for scaffolded targets');
+    });
+
+    // Host rejected for existing-endpoint
+    it('rejects --host with existing-endpoint', async () => {
+      const options: AddGatewayTargetOptions = {
+        name: 'test-tool',
+        source: 'existing-endpoint',
+        endpoint: 'https://example.com/mcp',
+        host: 'Lambda',
+      };
+      const result = await validateAddGatewayTargetOptions(options);
+      expect(result.valid).toBe(false);
+      expect(result.error).toBe('--host is not applicable for existing endpoint targets');
+    });
   });
 
   describe('validateAddMemoryOptions', () => {