Skip to content

Commit 578088f

Browse files
committed
fix: emit ValidationError instead of UnknownError in create telemetry
1 parent 1daed1b commit 578088f

3 files changed

Lines changed: 5 additions & 2 deletions

File tree

esbuild.config.mjs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ await esbuild.build({
4848
platform: 'node',
4949
format: 'esm',
5050
minify: true,
51+
keepNames: true,
5152
jsx: 'automatic',
5253
// Inject require shim for ESM compatibility with CommonJS dependencies
5354
banner: {

integ-tests/create-edge-cases.test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ describe.skipIf(!prereqs.npm || !prereqs.git)('integration: create edge cases',
3838
telemetry.assertMetricEmitted({
3939
command: 'create',
4040
exit_reason: 'failure',
41+
error_name: 'ValidationError',
42+
error_source: 'user',
4143
agent_language: 'python',
4244
has_agent: 'true',
4345
});

src/cli/commands/create/command.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { getWorkingDirectory, serializeResult } from '../../../lib';
1+
import { ValidationError, getWorkingDirectory, serializeResult } from '../../../lib';
22
import type {
33
BuildType,
44
ModelProvider,
@@ -132,7 +132,7 @@ async function handleCreateCLI(options: CreateOptions): Promise<void> {
132132
async () => {
133133
const validation = validateCreateOptions(options, cwd);
134134
if (!validation.valid) {
135-
throw new Error(validation.error);
135+
throw new ValidationError(validation.error!);
136136
}
137137
const green = '\x1b[32m';
138138
const reset = '\x1b[0m';

0 commit comments

Comments
 (0)