Skip to content

Commit 5ffb806

Browse files
committed
fix: address PR review feedback - type safety and naming consistency
- Replace `any` with `unknown`/`RemovableResource` in registry.ts - Remove unused `computeDefaultIdentityEnvVarName` alias from CredentialPrimitive and credential-utils
1 parent 220fef1 commit 5ffb806

3 files changed

Lines changed: 3 additions & 8 deletions

File tree

src/cli/primitives/CredentialPrimitive.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,6 @@ export class CredentialPrimitive extends BasePrimitive<AddCredentialOptions, Rem
193193
}
194194

195195
static computeDefaultCredentialEnvVarName = computeDefaultCredentialEnvVarName;
196-
static computeDefaultIdentityEnvVarName = computeDefaultCredentialEnvVarName;
197196

198197
/**
199198
* Resolve credential strategy for adding an agent.

src/cli/primitives/credential-utils.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,3 @@
66
export function computeDefaultCredentialEnvVarName(credentialName: string): string {
77
return `AGENTCORE_CREDENTIAL_${credentialName.replace(/-/g, '_').toUpperCase()}`;
88
}
9-
10-
// Alias for backward compatibility
11-
export const computeDefaultIdentityEnvVarName = computeDefaultCredentialEnvVarName;

src/cli/primitives/registry.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import { CredentialPrimitive } from './CredentialPrimitive';
44
import { GatewayPrimitive } from './GatewayPrimitive';
55
import { GatewayTargetPrimitive } from './GatewayTargetPrimitive';
66
import { MemoryPrimitive } from './MemoryPrimitive';
7+
import type { RemovableResource } from './types';
78

89
/**
910
* Singleton instances of all primitives.
@@ -17,8 +18,7 @@ export const gatewayTargetPrimitive = new GatewayTargetPrimitive();
1718
/**
1819
* All primitives in display order.
1920
*/
20-
// eslint-disable-next-line @typescript-eslint/no-explicit-any
21-
export const ALL_PRIMITIVES: BasePrimitive<any, any>[] = [
21+
export const ALL_PRIMITIVES: BasePrimitive<unknown, RemovableResource>[] = [
2222
agentPrimitive,
2323
memoryPrimitive,
2424
credentialPrimitive,
@@ -29,8 +29,7 @@ export const ALL_PRIMITIVES: BasePrimitive<any, any>[] = [
2929
/**
3030
* Look up a primitive by its kind.
3131
*/
32-
// eslint-disable-next-line @typescript-eslint/no-explicit-any
33-
export function getPrimitive(kind: string): BasePrimitive<any, any> {
32+
export function getPrimitive(kind: string): BasePrimitive<unknown, RemovableResource> {
3433
const primitive = ALL_PRIMITIVES.find(p => p.kind === kind);
3534
if (!primitive) {
3635
throw new Error(`Unknown primitive kind: ${kind}`);

0 commit comments

Comments
 (0)