fix: use consistent env var naming for credential providers (#146)

Use computeDefaultCredentialEnvVarName (AGENTCORE_CREDENTIAL_ prefix)
instead of accessing credential.envVars which no longer exists after
the schema migration.

This ensures the deploy command looks for the same env var name that
was set when the credential was created.

Author: tejaskash

src/cli/operations/deploy/pre-deploy-identity.ts

@@ -3,6 +3,7 @@ import type { AgentCoreProjectSpec, Credential } from '../../../schema';
 import { getCredentialProvider } from '../../aws';
 import { isNoCredentialsError } from '../../errors';
 import { apiKeyProviderExists, createApiKeyProvider, setTokenVaultKmsKey } from '../identity';
+import { computeDefaultCredentialEnvVarName } from '../identity/create-identity';
 import { BedrockAgentCoreControlClient } from '@aws-sdk/client-bedrock-agentcore-control';
 import { CreateKeyCommand, KMSClient } from '@aws-sdk/client-kms';
 
@@ -119,24 +120,12 @@ async function setupTokenVaultKms(
   }
 }
 
-/**
- * Get the environment variable name for a credential.
- * Uses the first envVar in the credential's envVars array, or generates a default.
- */
-function getCredentialEnvVarName(credential: Credential): string {
-  if (credential.envVars && credential.envVars.length > 0 && credential.envVars[0]) {
-    return credential.envVars[0].name;
-  }
-  // Default naming convention
-  return `AGENTCORE_IDENTITY_${credential.name.toUpperCase().replace(/[^A-Z0-9]/g, '_')}`;
-}
-
 async function setupApiKeyCredentialProvider(
   client: BedrockAgentCoreControlClient,
   credential: Credential,
   credentials: SecureCredentials
 ): Promise<ApiKeyProviderSetupResult> {
-  const envVarName = getCredentialEnvVarName(credential);
+  const envVarName = computeDefaultCredentialEnvVarName(credential.name);
   const apiKey = credentials.get(envVarName);
 
   if (!apiKey) {
@@ -200,7 +189,7 @@ export async function getMissingCredentials(
 
   for (const credential of projectSpec.credentials) {
     if (credential.type === 'ApiKeyCredentialProvider') {
-      const envVarName = getCredentialEnvVarName(credential);
+      const envVarName = computeDefaultCredentialEnvVarName(credential.name);
       if (!envVars[envVarName]) {
         missing.push({
           providerName: credential.name,