fix(test): update integration tests for credential rename and alias removal

Integration tests were still using `add identity` and `remove identity`
commands which no longer exist without the backward-compat aliases.

Confidence: high
Scope-risk: narrow

Author: jesseturner21

integ-tests/add-remove-gateway.test.ts

@@ -117,7 +117,7 @@ describe('integration: add and remove gateway with OpenAPI schema target', () =>
 
     it('creates an API key credential for outbound auth', async () => {
       const result = await runCLI(
-        ['add', 'identity', '--name', 'TestApiKey', '--api-key', 'test-key-123', '--json'],
+        ['add', 'credential', '--name', 'TestApiKey', '--api-key', 'test-key-123', '--json'],
         project.projectPath
       );
       expect(result.exitCode, `stdout: ${result.stdout}, stderr: ${result.stderr}`).toBe(0);
@@ -238,7 +238,7 @@ describe('integration: add gateway with S3 URI schema target', () => {
       expect(result.exitCode, `stdout: ${result.stdout}, stderr: ${result.stderr}`).toBe(0);
 
       const credResult = await runCLI(
-        ['add', 'identity', '--name', 'S3ApiKey', '--api-key', 'test-key', '--json'],
+        ['add', 'credential', '--name', 'S3ApiKey', '--api-key', 'test-key', '--json'],
         project.projectPath
       );
       expect(credResult.exitCode, `stdout: ${credResult.stdout}, stderr: ${credResult.stderr}`).toBe(0);
@@ -304,7 +304,10 @@ describe('integration: add gateway with S3 URI and bucketOwnerAccountId', () =>
 
   it('adds a gateway and target with --schema-s3-account', async () => {
     await runCLI(['add', 'gateway', '--name', gatewayName, '--json'], project.projectPath);
-    await runCLI(['add', 'identity', '--name', 'CrossApiKey', '--api-key', 'test-key', '--json'], project.projectPath);
+    await runCLI(
+      ['add', 'credential', '--name', 'CrossApiKey', '--api-key', 'test-key', '--json'],
+      project.projectPath
+    );
 
     const result = await runCLI(
       [

integ-tests/add-remove-resources.test.ts

@@ -80,12 +80,12 @@ describe('integration: add and remove resources', () => {
     });
   });
 
-  describe('identity lifecycle', () => {
-    const identityName = `IntegId${Date.now().toString().slice(-6)}`;
+  describe('credential lifecycle', () => {
+    const credentialName = `IntegId${Date.now().toString().slice(-6)}`;
 
-    it('adds an identity resource', async () => {
+    it('adds a credential resource', async () => {
       const result = await runCLI(
-        ['add', 'identity', '--name', identityName, '--api-key', 'test-key-integ-123', '--json'],
+        ['add', 'credential', '--name', credentialName, '--api-key', 'test-key-integ-123', '--json'],
         project.projectPath
       );
 
@@ -97,12 +97,12 @@ describe('integration: add and remove resources', () => {
       const config = await readProjectConfig(project.projectPath);
       const credentials = config.credentials as Record<string, unknown>[] | undefined;
       expect(credentials, 'credentials should exist').toBeDefined();
-      const found = credentials!.some((c: Record<string, unknown>) => c.name === identityName);
-      expect(found, `Identity "${identityName}" should be in config`).toBe(true);
+      const found = credentials!.some((c: Record<string, unknown>) => c.name === credentialName);
+      expect(found, `Credential "${credentialName}" should be in config`).toBe(true);
     });
 
-    it('removes the identity resource', async () => {
-      const result = await runCLI(['remove', 'identity', '--name', identityName, '--json'], project.projectPath);
+    it('removes the credential resource', async () => {
+      const result = await runCLI(['remove', 'credential', '--name', credentialName, '--json'], project.projectPath);
 
       expect(result.exitCode, `stdout: ${result.stdout}, stderr: ${result.stderr}`).toBe(0);
       const json = JSON.parse(result.stdout);
@@ -111,8 +111,8 @@ describe('integration: add and remove resources', () => {
       // Verify config updated
       const config = await readProjectConfig(project.projectPath);
       const credentials = (config.credentials as Record<string, unknown>[] | undefined) ?? [];
-      const found = credentials.some((c: Record<string, unknown>) => c.name === identityName);
-      expect(found, `Identity "${identityName}" should be removed from config`).toBe(false);
+      const found = credentials.some((c: Record<string, unknown>) => c.name === credentialName);
+      expect(found, `Credential "${credentialName}" should be removed from config`).toBe(false);
     });
   });
 });